Bug 114792

Summary:

Web Inspector: Toolbar icons are displayed incorrectly

Product:

WebKit

Reporter:

Seokju Kwon <seokju>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alph, commit-queue, graouts, joepeck, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
broken icons	none
Patch	none

Seokju Kwon

Reported 2013-04-18 01:25:23 PDT

Inspector uses small toolbar icons when docking the inspector. So they should have different x position. (Add missing 'background-position-x' values for CPU/CSS/Heap/Canvas/MemoryChart/MemorySnapshot Profilers.)

Attachments
broken icons (76.13 KB, image/png) 2013-04-18 01:26 PDT, Seokju Kwon	no flags	Details
Patch (3.14 KB, patch) 2013-04-18 01:29 PDT, Seokju Kwon	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Seokju Kwon

Comment 1 2013-04-18 01:26:07 PDT

Created attachment 198692 [details] broken icons

Seokju Kwon

Comment 2 2013-04-18 01:29:01 PDT

Created attachment 198693 [details] Patch

WebKit Commit Bot

Comment 3 2013-04-18 05:53:25 PDT

Comment on attachment 198693 [details] Patch Clearing flags on attachment: 198693 Committed r148668: <http://trac.webkit.org/changeset/148668>

WebKit Commit Bot

Comment 4 2013-04-18 05:53:27 PDT

All reviewed patches have been landed. Closing bug.

Joseph Pecoraro

Comment 5 2013-04-18 11:16:34 PDT

You may also want to file a Blink bug on this if it affects the inspector in Blink.

Timothy Hatcher

Comment 6 2013-04-18 11:19:19 PDT

I remember seeing a Blink fix go in for this.

Seokju Kwon

Comment 7 2013-04-18 20:06:32 PDT

@Joseph Pecoraro, Timothy Hatcher Thanks, I will check it on blink.

Alexei Filippov

Comment 8 2013-04-19 02:34:07 PDT

*** Bug 113700 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.