Summary: | Computed style of fill/stroke properties incorrect on references | ||
---|---|---|---|
Product: | WebKit | Reporter: | Dirk Schulze <krit> |
Component: | SVG | Assignee: | Rob Buis <rwlbuis> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | buildbot, commit-queue, d-r, esprehn+autocc, fmalita, glenn, macpherson, menard, pdr, rniwa, rwlbuis, schenney, zimmermann |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Attachments: |
Description
Dirk Schulze
2013-04-17 13:28:42 PDT
Created attachment 198604 [details]
Patch
Comment on attachment 198604 [details]
Patch
r=me
Comment on attachment 198604 [details] Patch Rejecting attachment 198604 [details] from commit-queue. New failing tests: transitions/svg-transitions.html Full output: http://webkit-queues.appspot.com/results/102492 Created attachment 198610 [details]
Archive of layout-test-results from webkit-cq-02 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-02 Port: mac-mountainlion Platform: Mac OS X 10.8.3
Comment on attachment 198604 [details] Patch Attachment 198604 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/65144 New failing tests: transitions/svg-transitions.html Created attachment 198667 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.2
Comment on attachment 198604 [details] Patch Attachment 198604 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/21329 New failing tests: transitions/svg-transitions.html Created attachment 198683 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2
(In reply to comment #8) > Created an attachment (id=198683) [details] > Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 > > The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. > Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2 Not sure if someone updates a result in the meantime, but I do not get this failure. Can some one post the output if it still occurs please? Never mind, see the output from the bot :P Created attachment 209607 [details]
Patch
Comment on attachment 209607 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=209607&action=review > Source/WebCore/css/CSSPrimitiveValue.cpp:1003 > + text = "url(" + quoteCSSURLIfNeeded(m_value.string) + ')'; Just snuck in a related optimization? (In reply to comment #12) > (From update of attachment 209607 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=209607&action=review > > > Source/WebCore/css/CSSPrimitiveValue.cpp:1003 > > + text = "url(" + quoteCSSURLIfNeeded(m_value.string) + ')'; > > Just snuck in a related optimization? Yes :) I figured since it was part of Dirk's original patch and Andreas okayed it it may as well go in like that. Comment on attachment 209607 [details] Patch Clearing flags on attachment: 209607 Committed r154628: <http://trac.webkit.org/changeset/154628> All reviewed patches have been landed. Closing bug. Did I forget to land it? (In reply to comment #16) > Did I forget to land it? The patch never landed AFAICT. |