| Summary: | [Qt][Mac] Remove obsolete workaround for debug builds | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andras Becsi <abecsi> | ||||||
| Component: | New Bugs | Assignee: | Andras Becsi <abecsi> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | jturcotte, vestbo, zeno | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 110211 | ||||||||
| Attachments: |
|
||||||||
|
Description
Andras Becsi
2013-04-17 11:01:17 PDT
Created attachment 198585 [details]
Patch
Created attachment 198587 [details]
Patch
Comment on attachment 198587 [details]
Patch
If this is broken there is good chance that all references to BASE_TARGET are also broken.
(In reply to comment #3) > (From update of attachment 198587 [details]) > If this is broken there is good chance that all references to BASE_TARGET are also broken. My understanding is that the BASE_TARGET hack only applies for framework builds of Qt, which do not have the version number in their name. (The corresponding issue was reported here https://bugreports.qt-project.org/browse/QTBUG-30466) This causes a problem for non-framework builds where we tried to support debug-only builds with this hack. My assumption is that this workaround was put in place to remove the "_debug" suffix and probably worked before the library split when there was no version number in the libraries. Btw, I tried both framework and non-framework builds with this, using build-webkit and simply qmake && make and both worked. The stable branch is also missing the BASE_TARGET hack from the widgets.pri, so I'm going to cherry-pick that from trunk. Personally I don't use the configuration covered by that code, so if Tor Arne and Zeno are good with it I think it's good. Comment on attachment 198587 [details]
Patch
r=me if you make sure they are OK with it.
(In reply to comment #7) > (From update of attachment 198587 [details]) > r=me if you make sure they are OK with it. Lgtm Comment on attachment 198587 [details] Patch Clearing flags on attachment: 198587 Committed r148789: <http://trac.webkit.org/changeset/148789> All reviewed patches have been landed. Closing bug. |