| Summary: | BasicShapeFunctions should use RenderStyle instead of StyleResolver | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Schulze <krit> | ||||||
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, esprehn+autocc, macpherson, menard | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Dirk Schulze
2013-04-17 07:50:38 PDT
Created attachment 198510 [details]
Patch
Attachment 198510 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/BasicShapeFunctions.cpp', u'Source/WebCore/css/BasicShapeFunctions.h', u'Source/WebCore/css/DeprecatedStyleBuilder.cpp']" exit_code: 1
Source/WebCore/css/BasicShapeFunctions.h:43: The parameter name "style" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 198510 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198510&action=review >> Source/WebCore/css/BasicShapeFunctions.h:43 >> +PassRefPtr<BasicShape> basicShapeForValue(RenderStyle* style, RenderStyle* rootElementStyle, const CSSBasicShape*); > > The parameter name "style" adds no information, so it should be removed. [readability/parameter_name] [5] These should be const. I would put the main input (the shape) first. Created attachment 198616 [details]
Patch fo landing
Comment on attachment 198616 [details] Patch fo landing Rejecting attachment 198616 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 198616, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: differ, using rebase: :040000 040000 acb0cf64aa1f0ec42b9dcae7d83d4f7e7d338ed1 21f93620f0f7e280e26e43b9489291f5ec959909 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Full output: http://webkit-queues.appspot.com/results/61388 Comment on attachment 198616 [details] Patch fo landing Clearing flags on attachment: 198616 Committed r148645: <http://trac.webkit.org/changeset/148645> All reviewed patches have been landed. Closing bug. |