|Summary:||[S60] Add support for flash setting enable/disable in webkit|
|Product:||WebKit||Reporter:||Shyam Sareen <shyam.sareen>|
|Component:||WebKit Misc.||Assignee:||Nobody <webkit-unassigned>|
|OS:||S60 3rd edition|
Description Shyam Sareen 2006-10-31 13:02:09 PST
CR 102-5682 in TSW.
Comment 1 Shyam Sareen 2006-10-31 13:20:24 PST
Created attachment 11310 [details] Changes in the webkit
Comment 2 Shyam Sareen 2006-10-31 13:21:16 PST
Created attachment 11311 [details] Changes in the webcore
Comment 3 zalan 2006-10-31 14:10:50 PST
Comment on attachment 11311 [details] Changes in the webcore r=me
Comment 5 Shyam Sareen 2006-11-01 06:22:32 PST
Created attachment 11325 [details] New patch for webkit. Please ignore prevoius attached patch for webkit. Use this patch.
Comment 6 Yongjun Zhang 2006-11-01 07:30:09 PST
Comment on attachment 11325 [details] New patch for webkit. Memory leak in CPluginSkin::NewL.
Comment 7 Yongjun Zhang 2006-11-01 08:04:59 PST
I was wrong about the memory leak. It looks quite odd however to return NULL in ::NewL function. It would be better to check the flash Mime type in functions where NewL is called.
Comment 8 Shyam Sareen 2006-11-01 08:26:00 PST
Created attachment 11328 [details] Avoided NULL retruning in NewL(..) Avoided NULL retruning in NewL(..).
Comment 9 Yongjun Zhang 2006-11-01 08:28:09 PST
Comment on attachment 11328 [details] Avoided NULL retruning in NewL(..) r = me
Comment 10 Yongjun Zhang 2006-11-01 08:42:59 PST
committed on R17517.
Comment 11 Bradley Morrison 2006-11-09 14:02:06 PST
Um, can this be closed?