Bug 11473

Summary:

[S60] Add support for flash setting enable/disable in webkit

Product:

WebKit

Reporter:

Shyam Sareen <shyam.sareen>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

CLOSED FIXED

Severity:

Normal

CC:

shyam.sareen

Priority:

Version:

420+

Hardware:

S60 Emulator

OS:

S60 3rd edition

Attachments:

Description	Flags
Changes in the webkit	bradley.morrison: review-
Changes in the webcore	zalan: review+
New patch for webkit.	yongjun.zhang: review-
Avoided NULL retruning in NewL(..)	yongjun.zhang: review+

Shyam Sareen

Reported 2006-10-31 13:02:09 PST

CR 102-5682 in TSW.

Attachments
Changes in the webkit (8.38 KB, patch) 2006-10-31 13:20 PST, Shyam Sareen	bradley.morrison: review-	Details Formatted Diff Diff
Changes in the webcore (1.15 KB, patch) 2006-10-31 13:21 PST, Shyam Sareen	zalan: review+	Details Formatted Diff Diff
New patch for webkit. (7.64 KB, patch) 2006-11-01 06:22 PST, Shyam Sareen	yongjun.zhang: review-	Details Formatted Diff Diff
Avoided NULL retruning in NewL(..) (7.31 KB, patch) 2006-11-01 08:26 PST, Shyam Sareen	yongjun.zhang: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Shyam Sareen

Comment 1 2006-10-31 13:20:24 PST

Created attachment 11310 [details] Changes in the webkit

Shyam Sareen

Comment 2 2006-10-31 13:21:16 PST

Created attachment 11311 [details] Changes in the webcore

alan

Comment 3 2006-10-31 14:10:50 PST

Comment on attachment 11311 [details] Changes in the webcore r=me

alan

Comment 4 2006-10-31 14:14:18 PST

webcore commit r17497

Shyam Sareen

Comment 5 2006-11-01 06:22:32 PST

Created attachment 11325 [details] New patch for webkit. Please ignore prevoius attached patch for webkit. Use this patch.

Yongjun Zhang

Comment 6 2006-11-01 07:30:09 PST

Comment on attachment 11325 [details] New patch for webkit. Memory leak in CPluginSkin::NewL.

Yongjun Zhang

Comment 7 2006-11-01 08:04:59 PST

I was wrong about the memory leak. It looks quite odd however to return NULL in ::NewL function. It would be better to check the flash Mime type in functions where NewL is called.

Shyam Sareen

Comment 8 2006-11-01 08:26:00 PST

Created attachment 11328 [details] Avoided NULL retruning in NewL(..) Avoided NULL retruning in NewL(..).

Yongjun Zhang

Comment 9 2006-11-01 08:28:09 PST

Comment on attachment 11328 [details] Avoided NULL retruning in NewL(..) r = me

Yongjun Zhang

Comment 10 2006-11-01 08:42:59 PST

committed on R17517.

Bradley Morrison

Comment 11 2006-11-09 14:02:06 PST

Um, can this be closed?

Bradley Morrison

Comment 12 2006-11-09 14:02:37 PST

Comment on attachment 11310 [details] Changes in the webkit clearing review flag.

Note You need to log in before you can comment on or make changes to this bug.