Bug 114719

Summary: JSONLayoutResultsGenerator should be merged into JSONResultsGenerator
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED INVALID    
Severity: Normal CC: benjamin, commit-queue, koivisto, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Cleanup bfulgham: review+

Ryosuke Niwa
Reported 2013-04-16 20:47:28 PDT
JSONLayoutResultsGenerator should be merged into JSONResultsGenerator
Attachments
Cleanup (32.25 KB, patch)
2013-04-16 20:48 PDT, Ryosuke Niwa 		bfulgham: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-04-16 20:48:32 PDT
Created attachment 198462 [details] Cleanup
WebKit Commit Bot
Comment 2 2013-04-16 20:49:27 PDT
Attachment 198462 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy/common/net/resultsjsonparser.py', u'Tools/Scripts/webkitpy/layout_tests/controllers/manager.py', u'Tools/Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py', u'Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py', u'Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py']" exit_code: 1 Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:204: whitespace before '}' [pep8/E202] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ryosuke Niwa
Comment 3 2013-04-16 20:49:53 PDT
Here’s so much over-generalized code in this class that it hurts :(
Brent Fulgham
Comment 4 2014-04-24 10:28:35 PDT
Comment on attachment 198462 [details] Cleanup r=me. Not sure if this still applies cleanly, but nice to see so much code bloat removed!
Sam Sneddon [:gsnedders]
Comment 5 2023-12-01 13:36:30 PST
This is now invalid as bug 265553 deleted it as dead code.
Note You need to log in before you can comment on or make changes to this bug.