Move applyProperty from StyleResolver to StyleBuilder.

• Component: CSS
• Status: RESOLVED WONTFIX

[Dirk Schulze]

Create a new class StyleBuilder, make it a member of StyleResolver and move applyProperty to this class.

[Dirk Schulze]

Created attachment 198454 [details]
Patch for testing

Test patch on EWS.

[WebKit Commit Bot]

Attachment 198454 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/css/CSSAllInOne.cpp', u'Source/WebCore/css/SVGCSSStyleSelector.cpp', u'Source/WebCore/css/StyleBuilder.cpp', u'Source/WebCore/css/StyleBuilder.h', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/css/StyleResolver.h', u'Source/WebCore/rendering/style/RenderStyle.h']" exit_code: 1
Source/WebCore/css/SVGCSSStyleSelector.cpp:39:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EFL EWS Bot]

Comment on attachment 198454 [details]
Patch for testing

Attachment 198454 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/170112

[Dirk Schulze]

Created attachment 198457 [details]
Patch

[WebKit Commit Bot]

Attachment 198457 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/css/CSSAllInOne.cpp', u'Source/WebCore/css/SVGCSSStyleSelector.cpp', u'Source/WebCore/css/StyleBuilder.cpp', u'Source/WebCore/css/StyleBuilder.h', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/css/StyleResolver.h', u'Source/WebCore/rendering/style/RenderStyle.h']" exit_code: 1
Source/WebCore/css/StyleBuilder.cpp:70:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/css/StyleBuilder.cpp:91:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 2 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EFL EWS Bot]

Comment on attachment 198457 [details]
Patch

Attachment 198457 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/9303

[Dirk Schulze]

Created attachment 198460 [details]
Patch

[EFL EWS Bot]

Comment on attachment 198460 [details]
Patch

Attachment 198460 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/8292

[Build Bot]

Comment on attachment 198460 [details]
Patch

Attachment 198460 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/56179

[Dirk Schulze]

Created attachment 198466 [details]
Patch - with CSS Variables fix

[Antti Koivisto]

Comment on attachment 198466 [details]
Patch - with CSS Variables fix

From IRC discussion it sounds like the goals and the end state of this work is unclear. We shouldn't do large refactoring like this until there is good understanding where we are going.

[Yuki Sekiguchi]

We came to the conclusion in the contributors meeting[1].

What is the status of this bug?
If no one have time to do single switch statement refactoring, I want to do this refactoring.

[1]: https://docs.google.com/document/d/1EsMhk1X9FjPGWByp33NxKqOOJaMwuGP8FzFl19o4L1M/edit?pli=1