Bug 114678

Summary:

Implement ruby-overhang

Product:

WebKit

Reporter:

Yuki Sekiguchi <yuki.sekiguchi>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ahmad.saleem792, allan.jensen, buildbot, commit-queue, esprehn+autocc, hyatt, macpherson, menard, mmaxfield, ntim, rniwa, simon.fraser, syoichi, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar, WebExposed

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

278892, 278893, 278896, 278954

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2	none
Patch	none
Patch	none
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion	none
Patch	beidson: review-, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion	none

Yuki Sekiguchi

Reported 2013-04-16 04:12:02 PDT

Ruby-overhang is defined by CSS3 Ruby: http://www.w3.org/TR/css3-ruby/#rubyover

Attachments
Patch (797.48 KB, patch) 2013-04-16 04:28 PDT, Yuki Sekiguchi	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (1.06 MB, application/zip) 2013-04-16 08:19 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (1.07 MB, application/zip) 2013-04-16 09:05 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (1.08 MB, application/zip) 2013-04-16 10:31 PDT, Build Bot	no flags	Details
Patch (1.63 MB, patch) 2013-04-16 21:55 PDT, Yuki Sekiguchi	no flags	Details Formatted Diff Diff
Patch (27.65 KB, patch) 2013-04-18 22:52 PDT, Yuki Sekiguchi	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (488.62 KB, application/zip) 2013-04-19 02:41 PDT, Build Bot	no flags	Details
Patch (27.65 KB, patch) 2013-04-19 03:02 PDT, Yuki Sekiguchi	beidson: review- buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (699.59 KB, application/zip) 2013-04-19 06:13 PDT, Build Bot	no flags	Details
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Yuki Sekiguchi

Comment 1 2013-04-16 04:28:18 PDT

Created attachment 198317 [details] Patch

Build Bot

Comment 2 2013-04-16 08:19:25 PDT

Comment on attachment 198317 [details] Patch Attachment 198317 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/165043 New failing tests: fast/writing-mode/Kusa-Makura-background-canvas.html

Build Bot

Comment 3 2013-04-16 08:19:26 PDT

Created attachment 198330 [details] Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.2

Build Bot

Comment 4 2013-04-16 09:05:12 PDT

Comment on attachment 198317 [details] Patch Attachment 198317 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/72459 New failing tests: fast/writing-mode/Kusa-Makura-background-canvas.html

Build Bot

Comment 5 2013-04-16 09:05:15 PDT

Created attachment 198334 [details] Archive of layout-test-results from webkit-ews-05 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.2

Build Bot

Comment 6 2013-04-16 10:31:23 PDT

Comment on attachment 198317 [details] Patch Attachment 198317 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/72480 New failing tests: fast/writing-mode/Kusa-Makura-background-canvas.html

Build Bot

Comment 7 2013-04-16 10:31:25 PDT

Created attachment 198343 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2

Ryosuke Niwa

Comment 8 2013-04-16 10:43:09 PDT

Has this feature been announced on webkit-dev? http://www.webkit.org/coding/adding-features.html

Yuki Sekiguchi

Comment 9 2013-04-16 21:55:34 PDT

Created attachment 198465 [details] Patch

Yuki Sekiguchi

Comment 10 2013-04-17 00:37:06 PDT

(In reply to comment #8) > Has this feature been announced on webkit-dev? > > http://www.webkit.org/coding/adding-features.html Thank you for your good advice. I announced this: https://lists.webkit.org/pipermail/webkit-dev/2013-April/024728.html

Yuki Sekiguchi

Comment 11 2013-04-18 22:52:54 PDT

Created attachment 198804 [details] Patch

Build Bot

Comment 12 2013-04-19 02:41:25 PDT

Comment on attachment 198804 [details] Patch Attachment 198804 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/51188 New failing tests: fast/ruby/ruby-overhang-getcomputedstyle.html

Build Bot

Comment 13 2013-04-19 02:41:27 PDT

Created attachment 198831 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.2

Yuki Sekiguchi

Comment 14 2013-04-19 03:02:57 PDT

Created attachment 198834 [details] Patch

Build Bot

Comment 15 2013-04-19 06:13:02 PDT

Comment on attachment 198834 [details] Patch Attachment 198834 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/184087 New failing tests: svg/batik/text/smallFonts.svg

Build Bot

Comment 16 2013-04-19 06:13:04 PDT

Created attachment 198847 [details] Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.2

Yuki Sekiguchi

Comment 17 2013-04-22 17:28:54 PDT

The test result says that smallFonts.svg is flaky, and this patch don't touch SVG or text related codes. This may be false positive.

Brady Eidson

Comment 18 2016-05-24 21:37:55 PDT

Comment on attachment 198834 [details] Patch r- to clear stale patches from the review queue

Ahmad Saleem

Comment 19 2022-09-03 14:43:05 PDT

I don't know whether this patch landed or not? Appreciate if someone can have a look and see if this can rebased and landed? Thanks! Since it is in Web-Spec and covered via test suite: https://test.csswg.org/harness/test/css-ruby-1_dev/ I am going to mark this as "New". Thanks!

Tim Nguyen (:ntim)

Comment 20 2024-09-13 13:21:35 PDT

rdar://135073891

Tim Nguyen (:ntim)

Comment 21 2024-09-13 13:22:42 PDT

All subtasks are fixed, this landed in STP: https://webkit.org/blog/15860/release-notes-for-safari-technology-preview-203/

Note You need to log in before you can comment on or make changes to this bug.