Bug 114678

Summary: Implement ruby-overhang
Product: WebKit Reporter: Yuki Sekiguchi <yuki.sekiguchi>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: ahmad.saleem792, allan.jensen, buildbot, commit-queue, esprehn+autocc, hyatt, macpherson, menard, mmaxfield, rniwa, simon.fraser, syoichi, zalan
Priority: P2 Keywords: WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion
none
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion
none
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
none
Patch
none
Patch
none
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion
none
Patch
beidson: review-, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion none

Description Yuki Sekiguchi 2013-04-16 04:12:02 PDT
Ruby-overhang is defined by CSS3 Ruby:
http://www.w3.org/TR/css3-ruby/#rubyover
Comment 1 Yuki Sekiguchi 2013-04-16 04:28:18 PDT
Created attachment 198317 [details]
Patch
Comment 2 Build Bot 2013-04-16 08:19:25 PDT
Comment on attachment 198317 [details]
Patch

Attachment 198317 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/165043

New failing tests:
fast/writing-mode/Kusa-Makura-background-canvas.html
Comment 3 Build Bot 2013-04-16 08:19:26 PDT
Created attachment 198330 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.2
Comment 4 Build Bot 2013-04-16 09:05:12 PDT
Comment on attachment 198317 [details]
Patch

Attachment 198317 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/72459

New failing tests:
fast/writing-mode/Kusa-Makura-background-canvas.html
Comment 5 Build Bot 2013-04-16 09:05:15 PDT
Created attachment 198334 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.2
Comment 6 Build Bot 2013-04-16 10:31:23 PDT
Comment on attachment 198317 [details]
Patch

Attachment 198317 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/72480

New failing tests:
fast/writing-mode/Kusa-Makura-background-canvas.html
Comment 7 Build Bot 2013-04-16 10:31:25 PDT
Created attachment 198343 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2
Comment 8 Ryosuke Niwa 2013-04-16 10:43:09 PDT
Has this feature been announced on webkit-dev?

http://www.webkit.org/coding/adding-features.html
Comment 9 Yuki Sekiguchi 2013-04-16 21:55:34 PDT
Created attachment 198465 [details]
Patch
Comment 10 Yuki Sekiguchi 2013-04-17 00:37:06 PDT
(In reply to comment #8)
> Has this feature been announced on webkit-dev?
> 
> http://www.webkit.org/coding/adding-features.html

Thank you for your good advice.
I announced this:
https://lists.webkit.org/pipermail/webkit-dev/2013-April/024728.html
Comment 11 Yuki Sekiguchi 2013-04-18 22:52:54 PDT
Created attachment 198804 [details]
Patch
Comment 12 Build Bot 2013-04-19 02:41:25 PDT
Comment on attachment 198804 [details]
Patch

Attachment 198804 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/51188

New failing tests:
fast/ruby/ruby-overhang-getcomputedstyle.html
Comment 13 Build Bot 2013-04-19 02:41:27 PDT
Created attachment 198831 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.2
Comment 14 Yuki Sekiguchi 2013-04-19 03:02:57 PDT
Created attachment 198834 [details]
Patch
Comment 15 Build Bot 2013-04-19 06:13:02 PDT
Comment on attachment 198834 [details]
Patch

Attachment 198834 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/184087

New failing tests:
svg/batik/text/smallFonts.svg
Comment 16 Build Bot 2013-04-19 06:13:04 PDT
Created attachment 198847 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.2
Comment 17 Yuki Sekiguchi 2013-04-22 17:28:54 PDT
The test result says that smallFonts.svg is flaky, and this patch don't touch SVG or text related codes.
This may be false positive.
Comment 18 Brady Eidson 2016-05-24 21:37:55 PDT
Comment on attachment 198834 [details]
Patch

r- to clear stale patches from the review queue
Comment 19 Ahmad Saleem 2022-09-03 14:43:05 PDT
I don't know whether this patch landed or not? Appreciate if someone can have a look and see if this can rebased and landed? Thanks!

Since it is in Web-Spec and covered via test suite:

https://test.csswg.org/harness/test/css-ruby-1_dev/

I am going to mark this as "New". Thanks!