Description
xuefeiren
2013-04-16 01:38:20 PDT
Created attachment 198471 [details]
remove warning (unused parameter ) in platform/graphics/blackberry
remove warning (unused parameter ) in platform/graphics/blackberry
Attachment 198471 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/platform/graphics/blackberry/CanvasLayerWebKitThread.cpp', u'Source/WebCore/platform/graphics/blackberry/FontBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/FontCacheBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/GlyphPageTreeNodeBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/GraphicsContextBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/ImageBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/LayerTiler.cpp', u'Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/PathBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/PatternBlackBerry.cpp']" exit_code: 1
Source/WebCore/platform/graphics/blackberry/FontBlackBerry.cpp:65: Extra space before ) [whitespace/parens] [2]
Total errors found: 1 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 198474 [details]
remove warning (unused parameter ) in platform/graphics/blackberry
remove warning (unused parameter ) in platform/graphics/blackberry
Created attachment 198480 [details]
remove warning ( unused parameter )
remove warning ( unused parameter ) in
WebCore/loader/blackberry
WebCore/platform/blackberry
/Source/JavaScriptCore/runtime/GCActivityCallbackBlackBerry.cpp
WebCore/platform/network/blackberry
Created attachment 198481 [details]
remove warning (unused parameter ) in /Source/WebKit/blackberry/Api
remove warning (unused parameter ) in /Source/WebKit/blackberry/Api
Attachment 198481 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/BackingStore.cpp', u'Source/WebKit/blackberry/Api/BlackBerryGlobal.cpp', u'Source/WebKit/blackberry/Api/WebOverlay.cpp', u'Source/WebKit/blackberry/Api/WebPage.cpp', u'Source/WebKit/blackberry/Api/WebPageCompositor.cpp']" exit_code: 1
Source/WebKit/blackberry/Api/BackingStore.cpp:497: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebKit/blackberry/Api/BackingStore.cpp:498: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 2 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 198483 [details]
remove warning (unused parameter ) in /Source/WebKit/blackberry/Api
remove warning (unused parameter ) in /Source/WebKit/blackberry/Api
Created attachment 198487 [details]
remove warning (unused parameter ) in Source/WebKit/blackberry/WebCoreSupport
remove warning (unused parameter ) in Source/WebKit/blackberry/WebCoreSupport
Attachment 198487 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp', u'Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.cpp', u'Source/WebKit/blackberry/WebCoreSupport/EditorClientBlackBerry.cpp', u'Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp', u'Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp', u'Source/WebKit/blackberry/WebCoreSupport/NetworkInfoClientBlackBerry.cpp', u'Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp', u'Source/WebKit/blackberry/WebCoreSupport/UserMediaClientImpl.cpp']" exit_code: 1
Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp:448: Omit int when using unsigned [runtime/unsigned] [1]
Total errors found: 1 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 198488 [details]
remove warning (unused parameter ) in Source/WebKit/blackberry/WebCoreSupport
remove warning (unused parameter ) in Source/WebKit/blackberry/WebCoreSupport
Created attachment 198490 [details]
remove warning (unused parameter ) in /Source/WebKit/blackberry/Api
remove warning (unused parameter ) in /Source/WebKit/blackberry/Api
Created attachment 198492 [details]
remove warning ( unused parameter ) in Source/JavaScriptCore Source/WebCore
remove warning ( unused parameter ) in Source/JavaScriptCore Source/WebCore
Created attachment 198495 [details]
remove warning (unused parameter ) in platform/graphics/blackberry
remove warning (unused parameter ) in platform/graphics/blackberry
Created attachment 198496 [details]
remove warning (unused parameter ) in Source/WebKit/blackberry/WebCoreSupport
remove warning (unused parameter ) in Source/WebKit/blackberry/WebCoreSupport
Attachment 198496 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp', u'Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.cpp', u'Source/WebKit/blackberry/WebCoreSupport/EditorClientBlackBerry.cpp', u'Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp', u'Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp', u'Source/WebKit/blackberry/WebCoreSupport/NetworkInfoClientBlackBerry.cpp', u'Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp', u'Source/WebKit/blackberry/WebCoreSupport/UserMediaClientImpl.cpp']" exit_code: 1
Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp:448: Omit int when using unsigned [runtime/unsigned] [1]
Total errors found: 1 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 198497 [details]
remove warning (unused parameter ) in Source/WebKit/blackberry/WebCoreSupport
remove warning (unused parameter ) in Source/WebKit/blackberry/WebCoreSupport
Comment on attachment 198497 [details]
remove warning (unused parameter ) in Source/WebKit/blackberry/WebCoreSupport
Looks good.
Comment on attachment 198497 [details] remove warning (unused parameter ) in Source/WebKit/blackberry/WebCoreSupport Rejecting attachment 198497 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 198497, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 148598 = 32ba4d80be77591635f4139ffb71c932dd6e228c r148599 = dfbc393ad5b4b84207afab5ff9e16e43dfe76495 r148600 = 84bb53e6e04f1cf9db666c324d522189941e6c2c Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.appspot.com/results/73119 (In reply to comment #18) > (From update of attachment 198497 [details]) > Rejecting attachment 198497 [details] from commit-queue. > > Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 198497, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit > > Last 500 characters of output: > -> origin/master > Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... > Currently at 148598 = 32ba4d80be77591635f4139ffb71c932dd6e228c > r148599 = dfbc393ad5b4b84207afab5ff9e16e43dfe76495 > r148600 = 84bb53e6e04f1cf9db666c324d522189941e6c2c > Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc > First, rewinding head to replay your work on top of it... > Fast-forwarded master to refs/remotes/origin/master. > > Full output: http://webkit-queues.appspot.com/results/73119 Oops! Xuefei, this needs a ChangeLog, I missed it in the review... (In reply to comment #19) > (In reply to comment #18) > > (From update of attachment 198497 [details] [details]) > > Rejecting attachment 198497 [details] [details] from commit-queue. > > > > Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 198497, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit > > > > Last 500 characters of output: > > -> origin/master > > Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... > > Currently at 148598 = 32ba4d80be77591635f4139ffb71c932dd6e228c > > r148599 = dfbc393ad5b4b84207afab5ff9e16e43dfe76495 > > r148600 = 84bb53e6e04f1cf9db666c324d522189941e6c2c > > Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc > > First, rewinding head to replay your work on top of it... > > Fast-forwarded master to refs/remotes/origin/master. > > > > Full output: http://webkit-queues.appspot.com/results/73119 > > Oops! Xuefei, this needs a ChangeLog, I missed it in the review... Xuefei, I add some warning fixes in my branch, see webkit/85b353cd93d18225fd4cffcbd5f68d12776ab6d1. Can you integrate it with your patch? (In reply to comment #20) > (In reply to comment #19) > Xuefei, I add some warning fixes in my branch, see webkit/85b353cd93d18225fd4cffcbd5f68d12776ab6d1. Can you integrate it with your patch? Sure Created attachment 198673 [details]
remove warning (unused parameter ) in platform/graphics/blackberry
remove warning (unused parameter ) in platform/graphics/blackberry
Created attachment 198680 [details]
remove warning ( unused parameter ) in Source/JavaScriptCore Source/WebCore
remove warning ( unused parameter ) in Source/JavaScriptCore Source/WebCore
Created attachment 198681 [details]
remove warning (unused parameter ) in /Source/WebKit/blackberry/Api
remove warning (unused parameter ) in /Source/WebKit/blackberry/Api
Created attachment 198682 [details]
remove warning (unused parameter ) in Source/WebKit/blackberry/WebCoreSupport
remove warning (unused parameter ) in Source/WebKit/blackberry/WebCoreSupport
Created attachment 198697 [details]
remove warning (unused parameter ) in WebKit/blackberry and DumpRenderTree/blackberry. etc
remove warning (unused parameter ) in WebKit/blackberry and DumpRenderTree/blackberry
Created attachment 198702 [details]
remove warning ( unused parameter ) in Source/JavaScriptCore Source/WebCore
remove warning ( unused parameter ) in Source/JavaScriptCore Source/WebCore
Created attachment 198703 [details]
remove warning (unused parameter ) in /Source/WebKit/blackberry/Api
remove warning (unused parameter ) in /Source/WebKit/blackberry/Api
Created attachment 198704 [details]
remove warning (unused parameter ) in Source/WebKit/blackberry/WebCoreSupport
remove warning (unused parameter ) in Source/WebKit/blackberry/WebCoreSupport
Created attachment 198705 [details]
remove warning (unused parameter ) in WebKit/blackberry and DumpRenderTree/blackberry. etc
remove warning (unused parameter ) in WebKit/blackberry and DumpRenderTree/blackberry. etc
Comment on attachment 198704 [details]
remove warning (unused parameter ) in Source/WebKit/blackberry/WebCoreSupport
LGTM.
Comment on attachment 198704 [details] remove warning (unused parameter ) in Source/WebKit/blackberry/WebCoreSupport Clearing flags on attachment: 198704 Committed r148667: <http://trac.webkit.org/changeset/148667> Comment on attachment 198703 [details]
remove warning (unused parameter ) in /Source/WebKit/blackberry/Api
Looks good.
Comment on attachment 198702 [details]
remove warning ( unused parameter ) in Source/JavaScriptCore Source/WebCore
LGTM.
Comment on attachment 198673 [details] remove warning (unused parameter ) in platform/graphics/blackberry View in context: https://bugs.webkit.org/attachment.cgi?id=198673&action=review > Source/WebCore/platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:238 > +void GraphicsContext3D::logFrameBufferStatus(int) This is wrong, line is still being used in debug builds in BBLOG. You'll need to test NDEBUG to do the right thing. Comment on attachment 198705 [details]
remove warning (unused parameter ) in WebKit/blackberry and DumpRenderTree/blackberry. etc
LGTM.
The commit-queue encountered the following flaky tests while processing attachment 198703 [details]: svg/as-image/img-relative-height.html bug 114140 (author: zimmermann@kde.org) The commit-queue is continuing to process your patch. Comment on attachment 198703 [details] remove warning (unused parameter ) in /Source/WebKit/blackberry/Api Clearing flags on attachment: 198703 Committed r148676: <http://trac.webkit.org/changeset/148676> Comment on attachment 198705 [details] remove warning (unused parameter ) in WebKit/blackberry and DumpRenderTree/blackberry. etc Clearing flags on attachment: 198705 Committed r148677: <http://trac.webkit.org/changeset/148677> Comment on attachment 198702 [details] remove warning ( unused parameter ) in Source/JavaScriptCore Source/WebCore Clearing flags on attachment: 198702 Committed r148678: <http://trac.webkit.org/changeset/148678> All reviewed patches have been landed. Closing bug. Xuefei, your previous cleanup patch broke the debug build. Can you merge the following change in your new patch? Thanks! diff --git a/Source/WebKit/blackberry/WebKitSupport/RenderQueue.cpp b/Source/WebKit/blackberry/WebKitSupport/RenderQueue.cpp index a6b8b95..16b7718 100644 --- a/Source/WebKit/blackberry/WebKitSupport/RenderQueue.cpp +++ b/Source/WebKit/blackberry/WebKitSupport/RenderQueue.cpp @@ -879,7 +879,7 @@ void RenderQueue::renderScrollZoomJobs(TileIndexList* outstandingJobs, TileIndex scrollZoomJobsCompleted(*outstandingJobs, completedJobs, shouldBlitWhenCompleted); } -void RenderQueue::scrollZoomJobsCompleted(const TileIndexList&, TileIndexList* completedJobs, bool shouldBlit) +void RenderQueue::scrollZoomJobsCompleted(const TileIndexList& outstandingJobs, TileIndexList* completedJobs, bool shouldBlit) { // Get rid of the completed list! ASSERT(outstandingJobs.isEmpty()); (In reply to comment #42) > Xuefei, your previous cleanup patch broke the debug build. ok,sorry about this,i'll fix it right now. |