Summary: | Composited layer that painted into composited ancestor is not repainted after moving | ||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hurnjoo Lee <hurnjoo.lee> | ||||||||||||||||||||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa, simon.fraser, webkit-bug-importer | ||||||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||||||||
Hardware: | Other | ||||||||||||||||||||||||
OS: | Linux | ||||||||||||||||||||||||
Attachments: |
|
Description
Hurnjoo Lee
2013-04-15 19:07:53 PDT
Created attachment 198217 [details]
Test case
Does this affect any real-world site? (In reply to comment #1) > Created an attachment (id=198217) [details] > Test case (In reply to comment #2) > Does this affect any real-world site? No, this bug was found when making other testcase. Created attachment 198823 [details]
patch
Comment on attachment 198823 [details]
patch
The change looks good, but you should be able to make a LayoutTest as a repaint test or a ref test.
Created attachment 199404 [details]
patch
add a ref test.
(In reply to comment #6) > (From update of attachment 198823 [details]) > The change looks good, but you should be able to make a LayoutTest as a repaint test or a ref test. Sorry for the delay. I made a ref-test instead of a manual test. Comment on attachment 199404 [details] patch Attachment 199404 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/214098 New failing tests: compositing/repaint/absolute-painted-into-composited-ancestor.html Created attachment 199414 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.2
Comment on attachment 199404 [details] patch Attachment 199404 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/210079 New failing tests: compositing/repaint/absolute-painted-into-composited-ancestor.html fast/repaint/japanese-rl-selection-repaint-in-regions.html Created attachment 199420 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2
Comment on attachment 199404 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=199404&action=review r+ but please improve the test and investigate the EWS failures. > LayoutTests/compositing/repaint/absolute-painted-into-composited-ancestor.html:27 > + function doTest() { > + setTimeout(function() { > + moveBox(); > + }, 100); 100ms is a very long timeout for a test; you should be able to use 10 or less. Created attachment 199593 [details]
updated patch for the ews.
(In reply to comment #13) Thanks for the review. > (From update of attachment 199404 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=199404&action=review > > r+ but please improve the test and investigate the EWS failures. EWS failures are still remaining. I am investigating it. > > > LayoutTests/compositing/repaint/absolute-painted-into-composited-ancestor.html:27 > > + function doTest() { > > + setTimeout(function() { > > + moveBox(); > > + }, 100); > > 100ms is a very long timeout for a test; you should be able to use 10 or less. Done. Comment on attachment 199593 [details] updated patch for the ews. Attachment 199593 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/228005 New failing tests: compositing/repaint/absolute-painted-into-composited-ancestor.html Created attachment 199639 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.2
Comment on attachment 199593 [details] updated patch for the ews. Attachment 199593 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/171270 New failing tests: compositing/repaint/absolute-painted-into-composited-ancestor.html Created attachment 199642 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.2
Created attachment 199985 [details]
Add a text repaint test instead of ref test
(In reply to comment #15) > (In reply to comment #13) > > Thanks for the review. > > > (From update of attachment 199404 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=199404&action=review > > > > r+ but please improve the test and investigate the EWS failures. > EWS failures are still remaining. I am investigating it. > > > > > > LayoutTests/compositing/repaint/absolute-painted-into-composited-ancestor.html:27 > > > + function doTest() { > > > + setTimeout(function() { > > > + moveBox(); > > > + }, 100); > > > > 100ms is a very long timeout for a test; you should be able to use 10 or less. > Done. The ref-test was not working correctly in MAC-WK1, so I added a text repaint test instead of the ref-test. Comment on attachment 199985 [details] Add a text repaint test instead of ref test View in context: https://bugs.webkit.org/attachment.cgi?id=199985&action=review > LayoutTests/ChangeLog:8 > + Add a text repait test to check the repainting of composited layer "repait" Created attachment 213651 [details]
Patch
(In reply to comment #22) > (From update of attachment 199985 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=199985&action=review > > > LayoutTests/ChangeLog:8 > > + Add a text repait test to check the repainting of composited layer > > "repait" Fixed. I'm sorry, r+ was canceled by my mistake. Could you please give r+ again? Comment on attachment 213651 [details] Patch Clearing flags on attachment: 213651 Committed r157108: <http://trac.webkit.org/changeset/157108> All reviewed patches have been landed. Closing bug. |