Bug 114649

Summary:

Build fix: removing contextMenuProxy left over

Product:

WebKit

Reporter:

Adenilson Cavalcanti Silva <savagobr>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

commit-queue, gyuyoung.kim, lucas.de.marchi, rakuco

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

All

Attachments:

Description	Flags
Remove faulty ASSERT	none

Adenilson Cavalcanti Silva

Reported 2013-04-15 16:38:55 PDT

Current trunk build is broken: //------------------------------------------------------------------------------------------------ [ 85%] In file included from /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/WebPageProxy.h:32:0, from /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/DefaultUndoController.h:26, from /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/efl/WebView.h:31, from /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/API/efl/EwkView.h:32, from /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/API/efl/EwkView.cpp:22: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/DrawingAreaProxy.h:71:18: warning: unused parameter ‘timeout’ [-Wunused-parameter] /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/API/efl/EwkView.cpp: In member function ‘void EwkView::showContextMenu(WKPoint, WKArrayRef)’: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/API/efl/EwkView.cpp:812:8: error: ‘contextMenuProxy’ was not declared in this scope make[2]: *** [Source/WebKit2/CMakeFiles/ewebkit2.dir/UIProcess/API/efl/EwkView.cpp.o] Error 1 //------------------------------------------------------------------------------------------------ This regression probably was introduced with http://trac.webkit.org/changeset/148434, and wasn't noticed since ASSERTs are not compiled in Release mode.

Attachments
Remove faulty ASSERT (1.55 KB, patch) 2013-04-15 16:42 PDT, Adenilson Cavalcanti Silva	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Adenilson Cavalcanti Silva

Comment 1 2013-04-15 16:42:22 PDT

Created attachment 198202 [details] Remove faulty ASSERT

Adenilson Cavalcanti Silva

Comment 2 2013-04-15 16:50:21 PDT

Already fixed in #114647. *** This bug has been marked as a duplicate of bug 114647 ***

Note You need to log in before you can comment on or make changes to this bug.