Bug 11463

Summary:

Move KCanvasTreeDebug into rendering/

Product:

WebKit

Reporter:

Nikolas Zimmermann <zimmermann>

Component:

SVG

Assignee:

Nikolas Zimmermann <zimmermann>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Initial patch	mitz: review-
Updated patch	none
Updated final patch	mjs: review+

Description Nikolas Zimmermann 2006-10-30 17:29:31 PST

Move one of the last files in the kcanvas/ subdirectory (KCanvasTreeDebug.cpp)
down into rendering/SVGRenderTreeAsText.cpp

Uploading patch soon.

Comment 1 Nikolas Zimmermann 2006-10-31 05:04:49 PST

Created attachment 11295 [details]
Initial patch

Comment 2 mitz 2006-10-31 05:21:52 PST

Comment on attachment 11295 [details]
Initial patch

Please keep #includes sorted (or sort them if you're touching them) and remove the function lists from the ChangeLog. Better yet, rewrite it as:
* kcanvas/KCanvasTreeDebug.cpp: Moved to rendering/SVGRenderTreeAsText.cpp

Comment 3 Nikolas Zimmermann 2006-10-31 10:03:46 PST

Created attachment 11301 [details]
Updated patch

This fixes Mitz's comments.

Comment 4 Nikolas Zimmermann 2006-10-31 10:06:02 PST

Created attachment 11302 [details]
Updated final patch

Eek, the previous patch had a conflict in the ChangeLog.

Comment 5 Maciej Stachowiak 2006-10-31 10:26:01 PST

Comment on attachment 11302 [details]
Updated final patch

r=me

Comment 6 Adam Roben (:aroben) 2006-10-31 11:11:39 PST

Landed in r17486