Bug 114620 – win_cmd_shell detection doesn't work under MSYS

• Component: WebKit Qt
• Status: RESOLVED FIXED

[Jonathan Liu]

Tools/qmake/mkspecs/features/default_pre.prf tries to detect if running under Windows cmd.exe.
This detect works for cmd.exe and Cygwin shell but fails for MSYS.

The detection simplified and improved to also detect MSYS properly:
win32:isEmpty(QMAKE_SH): CONFIG += win_cmd_shell

[Jonathan Liu]

Created attachment 198116 [details]
Patch

[Jocelyn Turcotte]

Comment on attachment 198116 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198116&action=review

> Tools/qmake/mkspecs/features/default_pre.prf:40
> +win32:isEmpty(QMAKE_SH): CONFIG += win_cmd_shell

As far as I know you can have sh.exe in your PATH even in cmd.exe, which this would break.

Maybe this changed but I've spent a lot of hours trying to tweak project files back and forth like this to make sure that QtWebKit could build in both MSYS and cmd.exe to the end concluding that it's just not worth it. Unless you want to commit to maintain this code yourself I would prefer that we stick to only supporting cmd.exe to have one well supported environment on Windows instead of two crappy ones.

[Jonathan Liu]

Created attachment 198117 [details]
Patch

[WebKit Commit Bot]

Attachment 198117 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/qmake/mkspecs/features/default_pre.prf']" exit_code: 1
Tools/ChangeLog:11:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jonathan Liu]

Created attachment 198118 [details]
Patch

[Jonathan Liu]

(In reply to comment #2)
> (From update of attachment 198116 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=198116&action=review
> 
> > Tools/qmake/mkspecs/features/default_pre.prf:40
> > +win32:isEmpty(QMAKE_SH): CONFIG += win_cmd_shell
> 
> As far as I know you can have sh.exe in your PATH even in cmd.exe, which this would break.

If you have sh.exe in your PATH, mingw32-make will use sh.exe instead of cmd.exe anyway so the commands in the Makefile generated should be UNIX shell commands.

[Jocelyn Turcotte]

Comment on attachment 198118 [details]
Patch

I'm still not enthousiastic about supporting building in MSYS but this does make things more robust on both sides, so r=me :)

[WebKit Commit Bot]

Comment on attachment 198118 [details]
Patch

Clearing flags on attachment: 198118

Committed r148435: <http://trac.webkit.org/changeset/148435>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.