Bug 114554

Summary:

[CMake] Replace *_LIBRARY_NAME with *_OUTPUT_NAME

Product:

WebKit

Reporter:

Patrick R. Gansterer <paroga>

Component:

Tools / Tests

Assignee:

Patrick R. Gansterer <paroga>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, commit-queue, eflews.bot, gyuyoung.kim, gyuyoung.kim, laszlo.gombos, rakuco, ryuan.choi, tmpsantos

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	gyuyoung.kim: review+
Patch	none
Patch	eflews.bot: commit-queue-
Patch	eflews.bot: commit-queue-
Patch	commit-queue: commit-queue-
Patch for landing	none

Patrick R. Gansterer

Reported 2013-04-13 01:18:56 PDT

[CMake] Replace *_LIBRARY_NAME with *_OUTPUT_NAME

Attachments
Patch (33.98 KB, patch) 2013-04-13 01:35 PDT, Patrick R. Gansterer	no flags	Details Formatted Diff Diff
Patch (34.00 KB, patch) 2013-04-13 07:51 PDT, Patrick R. Gansterer	gyuyoung.kim: review+	Details Formatted Diff Diff
Patch (35.05 KB, patch) 2013-05-17 05:34 PDT, Patrick R. Gansterer	no flags	Details Formatted Diff Diff
Patch (34.71 KB, patch) 2013-05-18 02:40 PDT, Patrick R. Gansterer	eflews.bot: commit-queue-	Details Formatted Diff Diff
Patch (37.97 KB, patch) 2013-05-18 03:45 PDT, Patrick R. Gansterer	eflews.bot: commit-queue-	Details Formatted Diff Diff
Patch (37.96 KB, patch) 2013-05-18 03:59 PDT, Patrick R. Gansterer	commit-queue: commit-queue-	Details Formatted Diff Diff
Patch for landing (37.96 KB, patch) 2013-05-18 04:08 PDT, Patrick R. Gansterer	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Patrick R. Gansterer

Comment 1 2013-04-13 01:35:10 PDT

Created attachment 197927 [details] Patch

Patrick R. Gansterer

Comment 2 2013-04-13 07:51:49 PDT

Created attachment 197938 [details] Patch

Patrick R. Gansterer

Comment 3 2013-05-14 23:05:00 PDT

EFL guys: ping

Ryuan Choi

Comment 4 2013-05-15 01:57:54 PDT

(In reply to comment #3) > EFL guys: ping Looks fine for me.

Gyuyoung Kim

Comment 5 2013-05-15 02:01:17 PDT

Comment on attachment 197938 [details] Patch Looks fine as well. Don't you need to get comment from BB as well ?

Patrick R. Gansterer

Comment 6 2013-05-15 02:03:33 PDT

(In reply to comment #5) > (From update of attachment 197938 [details]) > Looks fine as well. Don't you need to get comment from BB as well ? The ping was more about "CMake people" and not "EFL" (my fault :-/), so IMHO it's ok without any special BB approval, since it does not change any behaviour.

Patrick R. Gansterer

Comment 7 2013-05-17 05:34:24 PDT

Created attachment 202068 [details] Patch

Patrick R. Gansterer

Comment 8 2013-05-18 02:40:52 PDT

Created attachment 202198 [details] Patch

EFL EWS Bot

Comment 9 2013-05-18 03:03:42 PDT

Comment on attachment 202198 [details] Patch Attachment 202198 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/499171

EFL EWS Bot

Comment 10 2013-05-18 03:34:47 PDT

Comment on attachment 202198 [details] Patch Attachment 202198 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/487753

Patrick R. Gansterer

Comment 11 2013-05-18 03:45:43 PDT

Created attachment 202200 [details] Patch

WebKit Commit Bot

Comment 12 2013-05-18 03:50:21 PDT

Attachment 202200 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'CMakeLists.txt', u'ChangeLog', u'Source/CMakeLists.txt', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/shell/CMakeLists.txt', u'Source/PlatformEfl.cmake', u'Source/PlatformGTK.cmake', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/CMakeLists.txt', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebKit/CMakeLists.txt', u'Source/WebKit/ChangeLog', u'Source/WebKit/PlatformBlackBerry.cmake', u'Source/WebKit/PlatformEfl.cmake', u'Source/WebKit/efl/ChangeLog', u'Source/WebKit/efl/ewebkit.pc.in', u'Source/WebKit2/CMakeLists.txt', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/PlatformEfl.cmake', u'Source/WebKit2/efl/ewebkit2.pc.in', u'Source/cmake/OptionsBlackBerry.cmake', u'Source/cmake/OptionsEfl.cmake', u'Source/cmake/OptionsGTK.cmake', u'Source/cmake/WebKitHelpers.cmake', u'Source/cmake/gtest/CMakeLists.txt', u'Tools/ChangeLog', u'Tools/DumpRenderTree/efl/CMakeLists.txt', u'Tools/EWebLauncher/CMakeLists.txt', u'Tools/ImageDiff/CMakeLists.txt', u'Tools/MiniBrowser/efl/CMakeLists.txt', u'Tools/TestWebKitAPI/CMakeLists.txt', u'Tools/WebKitTestRunner/CMakeLists.txt', u'Tools/WebKitTestRunner/PlatformEfl.cmake', u'Tools/WinCELauncher/CMakeLists.txt']" exit_code: 1 Source/WebKit2/ChangeLog:14: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 1 in 35 files If any of these errors are false positives, please file a bug against check-webkit-style.

EFL EWS Bot

Comment 13 2013-05-18 03:57:27 PDT

Comment on attachment 202200 [details] Patch Attachment 202200 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/497333

Patrick R. Gansterer

Comment 14 2013-05-18 03:59:53 PDT

Created attachment 202201 [details] Patch

WebKit Commit Bot

Comment 15 2013-05-18 04:06:55 PDT

Comment on attachment 202201 [details] Patch Rejecting attachment 202201 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--non-interactive', 202201, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WTF/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/491675

Patrick R. Gansterer

Comment 16 2013-05-18 04:08:51 PDT

Created attachment 202202 [details] Patch for landing

WebKit Commit Bot

Comment 17 2013-05-18 04:36:20 PDT

Comment on attachment 202202 [details] Patch for landing Clearing flags on attachment: 202202 Committed r150336: <http://trac.webkit.org/changeset/150336>

WebKit Commit Bot

Comment 18 2013-05-18 04:36:25 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.