Bug 114552

Summary: Remove more Chromium specific code from webkitpy
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, dpranke, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 114553    
Attachments:
Description Flags
Cleanup pnormand: review+

Description Ryosuke Niwa 2013-04-13 00:51:17 PDT
Remove more Chromium specific code from webkitpy
Comment 1 Ryosuke Niwa 2013-04-13 00:51:39 PDT
Created attachment 197923 [details]
Cleanup
Comment 2 Philippe Normand 2013-04-13 00:57:28 PDT
Comment on attachment 197923 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=197923&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:-651
> -# Left here not to break anything.
> -class JSONResultsGenerator(JSONResultsGeneratorBase):

So that class is no longer used?
Comment 3 Ryosuke Niwa 2013-04-13 01:01:03 PDT
Committed r148352: <http://trac.webkit.org/changeset/148352>
Comment 4 Ryosuke Niwa 2013-04-13 01:03:58 PDT
(In reply to comment #2)
> (From update of attachment 197923 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=197923&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:-651
> > -# Left here not to break anything.
> > -class JSONResultsGenerator(JSONResultsGeneratorBase):
> 
> So that class is no longer used?

Yes, we should probably rename JSONResultsGeneratorBase to JSONResultsGenerator in a follow up.