Bug 114530 – requestFullscreen on the current fullscreen element should fire fullscreen error.

• Component: WebCore Misc.
• Status: NEW

[Jer Noble]

Cloned from <http://code.google.com/p/chromium/issues/detail?id=229803>:

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/28.0.1472.0 Safari/537.36

Steps to reproduce the problem:
1. Install the Window State example from the chrome-app-samples repo (https://github.com/GoogleChrome/chrome-app-samples/tree/master/window-state ) 
2. Launch it, then "Enter" next to HTML5 fullscreen
3. (App goes fullscreen) Click "Enter" again
4. Click "Exit"

What is the expected behavior?
App stops being fullscreen

What went wrong?
App stays fullscreen. Clicking "Exit" again will cause it to stop being fullscreen. You have to press "Exit" as many times as you've pressed "Enter". (These buttons are just calling webkitRequestFullscreen and webkitExitFullscreen respectively.)

WebStore page: 

Did this work before? No 

Chrome version: 28.0.1472.0  Channel: canary
OS Version: OS X 10.7.5

[Jer Noble]

[e-mail] commented <http://code.google.com/p/chromium/issues/detail?id=229803#c3> in the original bug:

"This is an error in WebKit & Blink (likely in Document.cpp), and not apps specific. Load https://github.com/GoogleChrome/chrome-app-samples/blob/master/window-state/window.html in Chrome and the same behavior exists.

The fullscreen specification https://dvcs.w3.org/hg/fullscreen/raw-file/tip/Overview.html does express this as an error, in:
- requestFullscreen() method must run these steps:
- If any of the following conditions are true, ... fullscreenerror:
  - "The context object's node document fullscreen element stack is not empty and its top element is not an ancestor of the context object."

In this case, the element is already fullscreen and the top of the stack, the element is not an ancestor of its self.


A work around is for an application to check document.webkitFullscreenElement before requesting fullscreen, so as to not make the same element fullscreen multiple times."

[Jer Noble]

*** Bug 114767 has been marked as a duplicate of this bug. ***

[Jer Noble]

Created attachment 198612 [details]
Patch

[Brent Fulgham]

Comment on attachment 198612 [details]
Patch

r=me.

[Ahmad Saleem]

This r+ patch didn't landed and I was not able to find reference to this code in Webkit GitHub (might be searching wrong).

Can anyone else see whether it is still an issue or need to be fixed or this is taken care of? Thanks!