Bug 114515

Summary:

[BlackBerry] Enable selecting text in single line input field without selection point being actually on the targeted text vertically

Product:

WebKit

Reporter:

Yongxin Dai <yodai>

Component:

WebKit BlackBerry

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, mifenton, rwlbuis, tonikitoo

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Yongxin Dai 2013-04-12 08:52:25 PDT

It is still hard to select text in URL bar with an inverted selection handle.  We can improve the issue by replacing the Y coordinate of selection point with Y coordinate of start caret for single line input filed.  Thus, the Y coordinate is always valid regardless of the actual location of the selection handle.

Comment 1 Yongxin Dai 2013-04-12 09:09:10 PDT

Created attachment 197857 [details]
Patch

Comment 2 Rob Buis 2013-04-12 13:12:23 PDT

Comment on attachment 197857 [details]
Patch

LGTM.

Comment 3 WebKit Commit Bot 2013-04-12 13:43:13 PDT

Comment on attachment 197857 [details]
Patch

Clearing flags on attachment: 197857

Committed r148302: <http://trac.webkit.org/changeset/148302>

Comment 4 WebKit Commit Bot 2013-04-12 13:43:14 PDT

All reviewed patches have been landed.  Closing bug.