Bug 114502

Summary:

Use view-sized tiles during live window resize.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Layout and Rendering

Assignee:

Andreas Kling <kling>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

buildbot, commit-queue, esprehn+autocc, kling, koivisto, rniwa, simon.fraser, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar, Performance

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	simon.fraser: review-, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2	none

Andreas Kling

Reported 2013-04-12 04:06:14 PDT

On pages with very complex render trees, we can improve responsiveness during window resize by rendering everything into a single tile instead of multiple ones. This buys us a couple of FPS when resizing the MAS, for instance.

Attachments
Proposed patch (5.14 KB, patch) 2013-04-12 04:45 PDT, Andreas Kling	simon.fraser: review- buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (795.29 KB, application/zip) 2013-04-12 05:52 PDT, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2013-04-12 04:07:43 PDT

<rdar://problem/13639664>

Andreas Kling

Comment 2 2013-04-12 04:45:46 PDT

Created attachment 197745 [details] Proposed patch

Build Bot

Comment 3 2013-04-12 05:52:21 PDT

Comment on attachment 197745 [details] Proposed patch Attachment 197745 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/131024 New failing tests: fast/repaint/japanese-rl-selection-repaint-in-regions.html

Build Bot

Comment 4 2013-04-12 05:52:23 PDT

Created attachment 197752 [details] Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2

Simon Fraser (smfr)

Comment 5 2013-04-12 09:05:08 PDT

I'm not sure I like this. It can cause a lot of tile thrash. Can we just optimize the painting code to not have as much overhead when painting into tiles?

Andreas Kling

Comment 6 2013-04-12 09:40:23 PDT

(In reply to comment #5) > I'm not sure I like this. It can cause a lot of tile thrash. Do you mean in the case where resizing doesn't cause any relayout / dirtying? > Can we just optimize the painting code to not have as much overhead when painting into tiles? Probably. Any bright ideas? Perhaps we could merge vertically adjacent tiles and render them in one go, and then break them up into separate tiles.

Simon Fraser (smfr)

Comment 7 2013-04-12 11:28:46 PDT

Comment on attachment 197745 [details] Proposed patch I don't think we should do this.

Andreas Kling

Comment 8 2013-04-12 12:43:39 PDT

(In reply to comment #7) > (From update of attachment 197745 [details]) > I don't think we should do this. Yeah, okay.

Note You need to log in before you can comment on or make changes to this bug.