|Summary:||[BlackBerry][CSS Filters] Non-image content disappears when filter applied|
|Product:||WebKit||Reporter:||Arvid Nilsson <anilsson>|
|Component:||WebKit BlackBerry||Assignee:||Arvid Nilsson <anilsson>|
|Severity:||Normal||CC:||anlo, cgarcia, commit-queue, jpetsovits, mifenton, rwlbuis, tonikitoo, xan.lopez|
|Version:||528+ (Nightly build)|
Description Arvid Nilsson 2013-04-12 02:07:52 PDT
For example: <div>Hello, world!</div> Applying style="-webkit-filter: blur(1px);" to this div makes it disappear. Sometimes it flickers into view or shows up depending on the order of rendering. PR 325051
Comment 2 Arvid Nilsson 2013-04-12 03:03:11 PDT
I have been considering whether to add a new layout test that tries to apply a filter to some text. However, there's no reason to believe that other ports would fail to do that - being able to apply filters to images and rectangles means they will be able to apply them to anything. A test like that would just be duplication of already tested functionality to all other ports, and thus contribute nothing of value. Also, the BlackBerry port doesn't have pixel tests up and running yet, so such a test would not actually prevent regression of this fix.
Comment 3 Arvid Nilsson 2013-04-12 03:03:47 PDT
For these reasons I decided against adding a new layout test. For other ports, this is really already covered by existing layout tests.
Comment 4 Carlos Garcia Campos 2013-04-12 03:06:28 PDT
Comment on attachment 197739 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197739&action=review > Source/WebCore/platform/graphics/blackberry/LayerFilterRenderer.cpp:712 > + glVertexAttribPointer(m_positionLocation, 2, GL_FLOAT, GL_FALSE, 0, &layer->getTransformedBounds() ); There's an extra space between &layer->getTransformedBounds() and the last parentheses.
Comment 5 Arvid Nilsson 2013-04-12 03:37:05 PDT
(In reply to comment #4) > (From update of attachment 197739 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=197739&action=review > > > Source/WebCore/platform/graphics/blackberry/LayerFilterRenderer.cpp:712 > > + glVertexAttribPointer(m_positionLocation, 2, GL_FLOAT, GL_FALSE, 0, &layer->getTransformedBounds() ); > > There's an extra space between &layer->getTransformedBounds() and the last parentheses. Thank you, I'll fix that before landing =)
Comment 7 WebKit Commit Bot 2013-04-15 02:17:02 PDT
Comment on attachment 198034 [details] Patch Clearing flags on attachment: 198034 Committed r148423: <http://trac.webkit.org/changeset/148423>
Comment 8 WebKit Commit Bot 2013-04-15 02:17:04 PDT
All reviewed patches have been landed. Closing bug.