Bug 114491

Summary: Move CachedRawResourceClient into a separate file
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebCore Misc.Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, japhet
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch mrowe: review+

Description Alexey Proskuryakov 2013-04-11 23:38:26 PDT
Further reducing include graph.
Comment 1 Alexey Proskuryakov 2013-04-11 23:41:09 PDT
Created attachment 197721 [details]
proposed patch
Comment 2 WebKit Commit Bot 2013-04-11 23:41:57 PDT
Attachment 197721 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/loader/DocumentLoader.cpp', u'Source/WebCore/loader/DocumentLoader.h', u'Source/WebCore/loader/DocumentThreadableLoader.h', u'Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp', u'Source/WebCore/loader/cache/CachedRawResource.cpp', u'Source/WebCore/loader/cache/CachedRawResource.h', u'Source/WebCore/loader/cache/CachedRawResourceClient.h', u'Source/WebCore/loader/icon/IconLoader.h', u'Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h']" exit_code: 1
Source/WebCore/loader/DocumentThreadableLoader.h:46:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alexey Proskuryakov 2013-04-12 00:14:59 PDT
Committed <http://trac.webkit.org/r148265>.