Summary: | REGRESSION (r141136): Wiki "Random article" function very broken | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
Component: | Page Loading | Assignee: | Brady Eidson <beidson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, commit-queue, japhet | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Brady Eidson
2013-04-11 16:55:54 PDT
Created attachment 197910 [details]
Patch v1
Still making sure I didn't break any other layout tests, but this is my plan.
Comment on attachment 197910 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=197910&action=review Does SubresourceLoader cover all the resources that may be affected? > Source/WebCore/loader/SubresourceLoader.cpp:137 > + // If this redirect takes us somewhere besides the final response URL of the resource we're revalidating, > + // then make this an unconditional GET request. I think that this "what" comment adds some value, but a "why" one would be even better. (In reply to comment #2) > (From update of attachment 197910 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=197910&action=review > > Does SubresourceLoader cover all the resources that may be affected? SubresourceLoader is the only thing that revalidates CachedResources, so it's an appropriate catch-all for accidentally reusing previously loaded resources. > > Source/WebCore/loader/SubresourceLoader.cpp:137 > > + // If this redirect takes us somewhere besides the final response URL of the resource we're revalidating, > > + // then make this an unconditional GET request. > > I think that this "what" comment adds some value, but a "why" one would be even better. I can definitely improve this. EWS never churned all the way through this, and running tests locally is proving to be a hit-or-miss PITA. I need to move forward with this one and watch the actual testers afterwards. (In reply to comment #3) > (In reply to comment #2) > > > Source/WebCore/loader/SubresourceLoader.cpp:137 > > > + // If this redirect takes us somewhere besides the final response URL of the resource we're revalidating, > > > + // then make this an unconditional GET request. > > > > I think that this "what" comment adds some value, but a "why" one would be even better. > > I can definitely improve this. Since I'd worked on other things for ~9 days, I forgot to address this comment. My apologies. Will fix in a followup Followed up in http://trac.webkit.org/changeset/148932 |