Bug 114431

Summary: Remove WTF_USE_PLATFORM_STRATEGIES
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, buildbot, rniwa, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 112162    
Bug Blocks:    
Attachments:
Description Flags
Patch
buildbot: commit-queue-
Fix typo darin: review+

Carlos Garcia Campos
Reported 2013-04-11 03:14:19 PDT
Once all ports implement platform strategies, we can remove the WTF_USE_PLATFORM_STRATEGIES define and get rid of all the #ifdefs. Now that chromium has been removed and wx is about to be removed, I think the only port not implementing platform strategies is BlackBerry.
Attachments
Patch (29.68 KB, patch)
2013-05-14 06:58 PDT, Carlos Garcia Campos 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Fix typo (29.68 KB, patch)
2013-05-14 08:11 PDT, Carlos Garcia Campos 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2013-05-14 06:58:56 PDT
Created attachment 201710 [details] Patch
Build Bot
Comment 2 2013-05-14 07:31:05 PDT
Comment on attachment 201710 [details] Patch Attachment 201710 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/474154
Build Bot
Comment 3 2013-05-14 08:00:00 PDT
Comment on attachment 201710 [details] Patch Attachment 201710 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/471177
Carlos Garcia Campos
Comment 4 2013-05-14 08:11:38 PDT
Created attachment 201716 [details] Fix typo
Darin Adler
Comment 5 2013-05-14 10:06:23 PDT
Comment on attachment 201716 [details] Fix typo View in context: https://bugs.webkit.org/attachment.cgi?id=201716&action=review > Source/WebCore/ChangeLog:8 > + No new tests, no new functionality. Normally it’s fine to just omit a line like this from the change log, unless you feel that it’s unclear without it.
Carlos Garcia Campos
Comment 6 2013-05-15 01:07:14 PDT
Committed r150104: <http://trac.webkit.org/changeset/150104>
Note You need to log in before you can comment on or make changes to this bug.