[CSS 3] support for cursor: all-scroll

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Lars Næsbye Christensen]

We should support more of the CSS 3 cursor style selectors. All-scroll could (for now) be the same as our 'move' cursor.

[Lars Næsbye Christensen]

Created attachment 11265 [details]
adds support for CSS cursor style all-scroll

Sets the 'move' cursor to be used for CSS cursor style="all-scroll"

[Maciej Stachowiak]

Comment on attachment 11265 [details]
adds support for CSS cursor style all-scroll

r=me

[Timothy Hatcher]

Landed in r17493

[David Kilzer (:ddkilzer)]

Comment on attachment 11265 [details]
adds support for CSS cursor style all-scroll

>Index: WebCore/css/CSSComputedStyleDeclaration.cpp
>===================================================================
>--- WebCore/css/CSSComputedStyleDeclaration.cpp	(revision 17395)
>+++ WebCore/css/CSSComputedStyleDeclaration.cpp	(working copy)
>@@ -680,6 +680,9 @@ PassRefPtr<CSSValue> CSSComputedStyleDec
>                 break;
>             case CURSOR_HELP:
>                 value = new CSSPrimitiveValue(CSS_VAL_HELP);
>+            case CURSOR_ALL_SCROLL:
>+                value = new CSSPrimitiveValue(CSS_VAL_ALL_SCROLL);
>+                break;
>         }
>         ASSERT(value);
>         if (list) {

I believe there is a missing "break;" statement after "case CURSOR_HELP:" now.  Patch forthcoming.

[David Kilzer (:ddkilzer)]

Reopening to fix missing "break;" statement.

[David Kilzer (:ddkilzer)]

Created attachment 11315 [details]
Fix missing "break;" statement from previous patch

Comment on attachment 11315 [details]
Fix missing "break;" statement from previous patch

r=me

[David Kilzer (:ddkilzer)]

Committed revision 17516 for Attachment 11315 [details].