Bug 11442

Summary:

[CSS 3] support for cursor: all-scroll

Product:

WebKit

Reporter:

Lars Næsbye Christensen <lars>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddkilzer, mjs

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
adds support for CSS cursor style all-scroll	mjs: review+
Fix missing "break;" statement from previous patch	mitz: review+

Lars Næsbye Christensen

Reported 2006-10-28 01:41:49 PDT

We should support more of the CSS 3 cursor style selectors. All-scroll could (for now) be the same as our 'move' cursor.

Attachments
adds support for CSS cursor style all-scroll (3.28 KB, patch) 2006-10-28 01:49 PDT, Lars Næsbye Christensen	mjs: review+	Details Formatted Diff Diff
Fix missing "break;" statement from previous patch (1.21 KB, patch) 2006-10-31 16:33 PST, David Kilzer (:ddkilzer)	mitz: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Lars Næsbye Christensen

Comment 1 2006-10-28 01:49:07 PDT

Created attachment 11265 [details] adds support for CSS cursor style all-scroll Sets the 'move' cursor to be used for CSS cursor style="all-scroll"

Maciej Stachowiak

Comment 2 2006-10-31 10:25:16 PST

Comment on attachment 11265 [details] adds support for CSS cursor style all-scroll r=me

Timothy Hatcher

Comment 3 2006-10-31 13:10:43 PST

Landed in r17493

David Kilzer (:ddkilzer)

Comment 4 2006-10-31 16:31:34 PST

Comment on attachment 11265 [details] adds support for CSS cursor style all-scroll >Index: WebCore/css/CSSComputedStyleDeclaration.cpp >=================================================================== >--- WebCore/css/CSSComputedStyleDeclaration.cpp (revision 17395) >+++ WebCore/css/CSSComputedStyleDeclaration.cpp (working copy) >@@ -680,6 +680,9 @@ PassRefPtr<CSSValue> CSSComputedStyleDec > break; > case CURSOR_HELP: > value = new CSSPrimitiveValue(CSS_VAL_HELP); >+ case CURSOR_ALL_SCROLL: >+ value = new CSSPrimitiveValue(CSS_VAL_ALL_SCROLL); >+ break; > } > ASSERT(value); > if (list) { I believe there is a missing "break;" statement after "case CURSOR_HELP:" now. Patch forthcoming.

David Kilzer (:ddkilzer)

Comment 5 2006-10-31 16:31:53 PST

Reopening to fix missing "break;" statement.

David Kilzer (:ddkilzer)

Comment 6 2006-10-31 16:33:17 PST

Created attachment 11315 [details] Fix missing "break;" statement from previous patch

mitz

Comment 7 2006-10-31 22:00:34 PST

Comment on attachment 11315 [details] Fix missing "break;" statement from previous patch r=me

David Kilzer (:ddkilzer)

Comment 8 2006-11-01 03:55:05 PST

Committed revision 17516 for Attachment 11315 [details].

Note You need to log in before you can comment on or make changes to this bug.