Bug 11437

Summary: use of uninitialized variable
Product: WebKit Reporter: David Carson <dacarson>
Component: HTML EditingAssignee: David Carson <dacarson>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
URL: http://www.google.com
Attachments:
Description Flags
patch to init value to false beidson: review+

Description David Carson 2006-10-27 11:58:23 PDT
In the function SelectionController::setModifyBias(), the case EXTEND: is be hit before m_modifyBiasSet has been initialized. The case funciton looks like this:
case EXTEND:
            if (!m_modifyBiasSet) {
                m_modifyBiasSet = true;
....

It is being hit when the user first starts to type something into the search box on www.google.com.
Not sure what the value should be initialized to.
Comment 1 David Carson 2006-10-27 13:27:44 PDT
From the looks of the code, it seems as if the value should be initialized to false.
Comment 2 David Carson 2006-10-27 13:36:02 PDT
Created attachment 11259 [details]
patch to init value to false
Comment 3 Brady Eidson 2006-10-27 13:55:40 PDT
Comment on attachment 11259 [details]
patch to init value to false

r=me
Comment 4 Sam Weinig 2006-10-28 12:07:41 PDT
Landed in r17400.