Bug 11437

Summary: use of uninitialized variable
Product: WebKit Reporter: David Carson <dacarson>
Component: HTML EditingAssignee: David Carson <dacarson>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
URL: http://www.google.com
Attachments:
Description Flags
patch to init value to false beidson: review+

David Carson
Reported 2006-10-27 11:58:23 PDT
In the function SelectionController::setModifyBias(), the case EXTEND: is be hit before m_modifyBiasSet has been initialized. The case funciton looks like this: case EXTEND: if (!m_modifyBiasSet) { m_modifyBiasSet = true; .... It is being hit when the user first starts to type something into the search box on www.google.com. Not sure what the value should be initialized to.
Attachments
patch to init value to false (1.04 KB, patch)
2006-10-27 13:36 PDT, David Carson 		beidson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Carson
Comment 1 2006-10-27 13:27:44 PDT
From the looks of the code, it seems as if the value should be initialized to false.
David Carson
Comment 2 2006-10-27 13:36:02 PDT
Created attachment 11259 [details] patch to init value to false
Brady Eidson
Comment 3 2006-10-27 13:55:40 PDT
Comment on attachment 11259 [details] patch to init value to false r=me
Sam Weinig
Comment 4 2006-10-28 12:07:41 PDT
Landed in r17400.
Note You need to log in before you can comment on or make changes to this bug.