Summary: | Replace ENABLE_CSS_* preprocessor statements in IDL files with Conditional attribute | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Patrick R. Gansterer <paroga> | ||||
Component: | WebCore Misc. | Assignee: | Patrick R. Gansterer <paroga> | ||||
Status: | NEW --- | ||||||
Severity: | Normal | CC: | buildbot, ggaren, rniwa | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 67400 | ||||||
Attachments: |
|
Description
Patrick R. Gansterer
2013-04-10 03:50:26 PDT
Created attachment 197239 [details]
Patch
Comment on attachment 197239 [details] Patch Attachment 197239 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17634134 Comment on attachment 197239 [details] Patch Attachment 197239 [details] did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/17712016 I believe the problem here is that DOM*.h is public API, and ENABLE(XXX) macros don't work in public API: ERROR: '/Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Headers/DOMCSSRule.h:45' included forbidden macro 'ENABLE' => '#if ENABLE(CSS3_CONDITIONAL_RULES)' ERROR: '/Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Headers/DOMCSSRule.h:48' included forbidden macro 'ENABLE' => '#if ENABLE(CSS_DEVICE_ADAPTATION)' ERROR: '/Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Headers/DOMCSSRule.h:51' included forbidden macro 'ENABLE' => '#if ENABLE(CSS_REGIONS)' ERROR: '/Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Headers/DOMCSSRule.h:54' included forbidden macro 'ENABLE' => '#if ENABLE(CSS_SHADERS)' Command /bin/sh failed with exit code 1 ** BUILD FAILED ** The following build commands failed: PhaseScriptExecution "Check For Inappropriate Macros in External Headers" /Volumes/Data/EWS/WebKit/WebKitBuild/WebKit.build/Release/WebKit.build/Script-A55DEAA516703F9F003DB841.sh |