Bug 114292

Summary: [GoodNotGreat] Throttle resize events during live window resize.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, commit-queue, ggaren, kling, koivisto, sam
Priority: P2 Keywords: InRadar, Performance
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
ggaren: review+
Revert "Throttle resize events during live window resize." none

Andreas Kling
Reported 2013-04-09 10:21:48 PDT
<rdar://problem/13411454>
Attachments
Proposed patch (5.98 KB, patch)
2013-04-09 10:23 PDT, Andreas Kling 		ggaren: review+
DetailsFormatted DiffDiff
Revert "Throttle resize events during live window resize." (4.04 KB, patch)
2013-04-23 06:15 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-04-09 10:23:38 PDT
Created attachment 197142 [details] Proposed patch
Geoffrey Garen
Comment 2 2013-04-09 10:27:42 PDT
Comment on attachment 197142 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=197142&action=review r=me > Source/WebCore/page/FrameView.cpp:2774 > +void FrameView::willEndLiveResize() Should we do this for all scrollable areas? What's unique about frame resizing?
Andreas Kling
Comment 3 2013-04-09 10:31:00 PDT
(In reply to comment #2) > (From update of attachment 197142 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=197142&action=review > > r=me > > > Source/WebCore/page/FrameView.cpp:2774 > > +void FrameView::willEndLiveResize() > > Should we do this for all scrollable areas? What's unique about frame resizing? Resize events are only sent from FrameView::performPostLayoutTasks() AFAIK.
Andreas Kling
Comment 4 2013-04-09 10:43:59 PDT
Committed r148031: <http://trac.webkit.org/changeset/148031>
Andreas Kling
Comment 5 2013-04-23 06:15:39 PDT
Created attachment 199224 [details] Revert "Throttle resize events during live window resize."
Andreas Kling
Comment 6 2013-04-23 06:16:30 PDT
Reopening to revert.
Geoffrey Garen
Comment 7 2013-04-23 11:41:58 PDT
Comment on attachment 199224 [details] Revert "Throttle resize events during live window resize." r=me
WebKit Commit Bot
Comment 8 2013-04-23 15:35:12 PDT
Comment on attachment 199224 [details] Revert "Throttle resize events during live window resize." Clearing flags on attachment: 199224 Committed r149002: <http://trac.webkit.org/changeset/149002>
WebKit Commit Bot
Comment 9 2013-04-23 15:35:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.