Bug 114292

Summary: [GoodNotGreat] Throttle resize events during live window resize.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, commit-queue, ggaren, kling, koivisto, sam
Priority: P2 Keywords: InRadar, Performance
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
ggaren: review+
Revert "Throttle resize events during live window resize." none

Description Andreas Kling 2013-04-09 10:21:48 PDT
<rdar://problem/13411454>
Comment 1 Andreas Kling 2013-04-09 10:23:38 PDT
Created attachment 197142 [details]
Proposed patch
Comment 2 Geoffrey Garen 2013-04-09 10:27:42 PDT
Comment on attachment 197142 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197142&action=review

r=me

> Source/WebCore/page/FrameView.cpp:2774
> +void FrameView::willEndLiveResize()

Should we do this for all scrollable areas? What's unique about frame resizing?
Comment 3 Andreas Kling 2013-04-09 10:31:00 PDT
(In reply to comment #2)
> (From update of attachment 197142 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=197142&action=review
> 
> r=me
> 
> > Source/WebCore/page/FrameView.cpp:2774
> > +void FrameView::willEndLiveResize()
> 
> Should we do this for all scrollable areas? What's unique about frame resizing?

Resize events are only sent from FrameView::performPostLayoutTasks() AFAIK.
Comment 4 Andreas Kling 2013-04-09 10:43:59 PDT
Committed r148031: <http://trac.webkit.org/changeset/148031>
Comment 5 Andreas Kling 2013-04-23 06:15:39 PDT
Created attachment 199224 [details]
Revert "Throttle resize events during live window resize."
Comment 6 Andreas Kling 2013-04-23 06:16:30 PDT
Reopening to revert.
Comment 7 Geoffrey Garen 2013-04-23 11:41:58 PDT
Comment on attachment 199224 [details]
Revert "Throttle resize events during live window resize."

r=me
Comment 8 WebKit Commit Bot 2013-04-23 15:35:12 PDT
Comment on attachment 199224 [details]
Revert "Throttle resize events during live window resize."

Clearing flags on attachment: 199224

Committed r149002: <http://trac.webkit.org/changeset/149002>
Comment 9 WebKit Commit Bot 2013-04-23 15:35:14 PDT
All reviewed patches have been landed.  Closing bug.