Bug 114266 – Get rid of truncated thread name warnings for non-Windows platforms

• Component: Web Template Framework
• Status: RESOLVED FIXED

[Thiago Marcos P. Santos]

ERROR: Thread name "com.apple.WebKit.ProcessLauncher" is longer than 31 characters and will be truncated by Visual Studio
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WTF/wtf/Threading.cpp(78) : WTF::ThreadIdentifier WTF::createThread(WTF::ThreadFunction, void*, const char*)
ERROR: Thread name "com.apple.WebKit.EventDispatcher" is longer than 31 characters and will be truncated by Visual Studio
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WTF/wtf/Threading.cpp(78) : WTF::ThreadIdentifier WTF::createThread(WTF::ThreadFunction, void*, const char*)
ERROR: Thread name "com.apple.WebKit.PluginProcessConnectionManager" is longer than 31 characters and will be truncated by Visual Studio
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WTF/wtf/Threading.cpp(78) : WTF::ThreadIdentifier WTF::createThread(WTF::ThreadFunction, void*, const char*)

[Thiago Marcos P. Santos]

Created attachment 197032 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 197032 [details]
Patch

We had this enabled for all platforms because it seemed likely that long thread names would keep being introduced if the warning only appeared on Windows. But apparently this warning isn't effective. Maybe we should make it a compile-time error instead?

[Thiago Marcos P. Santos]

(In reply to comment #2)
> (From update of attachment 197032 [details])
> We had this enabled for all platforms because it seemed likely that long thread names would keep being introduced if the warning only appeared on Windows. But apparently this warning isn't effective. Maybe we should make it a compile-time error instead?

Not a Windows expert, but looks to me that you will have a problem only if the truncated names are the same, which doesn't happen today. Maybe is a better idea just keep my patch and file a bug if the collision ever occurs one day.

[WebKit Commit Bot]

Comment on attachment 197032 [details]
Patch

Clearing flags on attachment: 197032

Committed r148166: <http://trac.webkit.org/changeset/148166>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

This is unfortunate for code that actually is used on Windows as well as other ports. We’d like to notice that the thread names are no good before actually running on Windows.

It seems that the problem comes with code that has no intention of running on Windows, getting warnings about a non-problem.

I guess we can just not worry about this any more unless the confusing thread names on Windows become a real world problem for someone, and then we can revisit this.