Bug 114234

Summary:

[WK2] Remove build warnings for unused parameters

Product:

WebKit

Reporter:

Jinwoo Song <jinwoo7.song>

Component:

WebKit Misc.

Assignee:

Jinwoo Song <jinwoo7.song>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alecflett, cmarcelo, commit-queue, dgrogan, eric.carlson, gustavo, gyuyoung.kim, jer.noble, jsbell, luiz, menard, mrobinson, noam, pnormand, webkit.review.bot, zeno

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Jinwoo Song

Reported 2013-04-08 20:38:36 PDT

There are a lot of build warnings for unused parameters. /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:622:6: warning: unused parameter ‘transaction’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:658:6: warning: unused parameter ‘transaction’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:1360:6: warning: unused parameter ‘transaction’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:1367:6: warning: unused parameter ‘transaction’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:1374:6: warning: unused parameter ‘transaction’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.h:57:21: warning: unused parameter ‘max’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp:210:6: warning: unused parameter ‘end’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp:1003:1: warning: unused parameter ‘type’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.h:57:21: warning: unused parameter ‘max’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp:451:29: warning: unused parameter ‘securityOrigin’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp:451:29: warning: unused parameter ‘levelDBFactory’ [-Wunused-parameter] [ 37%] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebCore/platform/leveldb/LevelDBDatabase.cpp:89:18: warning: unused parameter ‘start’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebCore/platform/leveldb/LevelDBDatabase.cpp:89:18: warning: unused parameter ‘limit’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebCore/platform/leveldb/LevelDBDatabase.cpp:90:18: warning: unused parameter ‘key’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebCore/bindings/js/IDBBindingUtilities.cpp:60:13: warning: unused parameter ‘keyPathElement’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:380:13: warning: unused parameter ‘pipeline’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebKit2/UIProcess/WebContext.cpp:1139:6: warning: unused parameter ‘request’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebKit2/UIProcess/WebContext.cpp:1225:6: warning: unused parameter ‘store’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebKit2/UIProcess/WebPageProxy.cpp:2644:6: warning: unused parameter ‘connection’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebKit2/WebProcess/WebProcess.cpp:797:6: warning: unused parameter ‘page’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebKit2/WebProcess/Storage/StorageAreaProxy.cpp:151:6: warning: unused parameter ‘key’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebKit2/WebProcess/Storage/StorageAreaProxy.cpp:151:6: warning: unused parameter ‘sourceFrame’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebKit2/WebProcess/Storage/StorageAreaProxy.cpp:157:6: warning: unused parameter ‘sourceFrame’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebKit2/WebProcess/Storage/StorageAreaProxy.cpp:287:6: warning: unused parameter ‘key’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebKit2/WebProcess/Storage/StorageAreaProxy.cpp:287:6: warning: unused parameter ‘oldValue’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebKit2/WebProcess/Storage/StorageAreaProxy.cpp:287:6: warning: unused parameter ‘newValue’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebKit2/WebProcess/Storage/StorageAreaProxy.cpp:287:6: warning: unused parameter ‘urlString’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebKit2/WebProcess/Storage/StorageAreaProxy.cpp:294:6: warning: unused parameter ‘key’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebKit2/WebProcess/Storage/StorageAreaProxy.cpp:294:6: warning: unused parameter ‘oldValue’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebKit2/WebProcess/Storage/StorageAreaProxy.cpp:294:6: warning: unused parameter ‘newValue’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebKit2/WebProcess/Storage/StorageAreaProxy.cpp:294:6: warning: unused parameter ‘urlString’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebKit2/WebProcess/WebPage/WebPage.cpp:3913:6: warning: unused parameter ‘frame’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:264:6: warning: unused parameter ‘pageOverlay’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebKit2/UIProcess/Storage/StorageManager.cpp:164:6: warning: unused parameter ‘newSessionStorageNamespace’ [-Wunused-parameter]

Attachments
Patch (15.28 KB, patch) 2013-04-08 20:43 PDT, Jinwoo Song	no flags	Details Formatted Diff Diff
Patch (15.18 KB, patch) 2013-04-08 22:16 PDT, Jinwoo Song	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jinwoo Song

Comment 1 2013-04-08 20:43:16 PDT

Created attachment 196987 [details] Patch

Jinwoo Song

Comment 2 2013-04-08 22:16:01 PDT

Created attachment 196997 [details] Patch

Andreas Kling

Comment 3 2013-04-09 02:24:10 PDT

Comment on attachment 196997 [details] Patch Looks okay. r=me

WebKit Commit Bot

Comment 4 2013-04-09 03:01:54 PDT

Comment on attachment 196997 [details] Patch Clearing flags on attachment: 196997 Committed r148000: <http://trac.webkit.org/changeset/148000>

WebKit Commit Bot

Comment 5 2013-04-09 03:01:59 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.