Bug 11421

Summary: REGRESSION (r17299): Crash in loadrequest when opening a link with target="_blank"
Product: WebKit Reporter: Kevin M. Dean <kevin>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: miles_b, mitz, saturn, sullivan
Priority: P1 Keywords: EasyFix, Regression
Version: 420+   
Hardware: Mac (PowerPC)   
OS: OS X 10.4   
URL: http://forums.appleinsider.com/showthread.php?t=67783
Attachments:
Description Flags
Crash Log none

Kevin M. Dean
Reported 2006-10-26 07:14:05 PDT
Load the link and then click on any of the links users have posted in their messages.
Attachments
Crash Log (26.95 KB, text/plain)
2006-10-26 07:14 PDT, Kevin M. Dean 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Kevin M. Dean
Comment 1 2006-10-26 07:14:39 PDT
Created attachment 11223 [details] Crash Log
Kevin M. Dean
Comment 2 2006-10-26 07:20:04 PDT
r17298 works fine
mitz
Comment 3 2006-10-26 07:24:50 PDT
Missing null check on the result of find() here:- WebCoreFrameBridge *targetFrame = [_bridge findFrameNamed:request.m_frameName]; - if (![_bridge canTargetLoadInFrame:targetFrame]) { + WebCoreFrameBridge *targetFrame = Mac(tree()->find(request.m_frameName))->bridge(); + if (![_bridge canTargetLoadInFrame:targetFrame])
mitz
Comment 4 2006-10-26 12:55:49 PDT
*** Bug 11425 has been marked as a duplicate of this bug. ***
Miles Bainbridge
Comment 5 2006-10-26 14:05:52 PDT
This seems to be happening on all target="_blank" and similar links for me, even after trashing all prefs and caches.
John Sullivan
Comment 6 2006-10-26 20:56:02 PDT
I fixed at least some of these problems via radar 4806064. Fix is in svn revision 17352. Please test any specific cases you know of since there might be some code paths that the case I was seeing didn't hit.
John Sullivan
Comment 7 2006-10-26 20:57:16 PDT
*** Bug 11426 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.