Bug 11415

Summary: REGRESSION: Selection change performed even when delete delegate replies NO
Product: WebKit Reporter: Duncan Wilcox <duncan>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar, Regression
Priority: P1    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Test case none

Duncan Wilcox
Reported 2006-10-25 15:22:51 PDT
If webView:shouldDeleteDOMRange: replies NO, WebCore/editing/TypingCommand.cpp still performs selection changes and webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting: is called shortly thereafter (incidentally with dangling proposed selection nodes). What seems to be happening is that TypingCommand::deleteKeyPressed(TextGranularity) and TypingCommand::forwardDeleteKeyPressed(TextGranularity) are performing selection changes before making sure that document()->frame()->shouldDeleteSelection(selectionToDelete) is checked.
Attachments
Test case (1.23 KB, text/plain)
2006-10-25 15:24 PDT, Duncan Wilcox 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Duncan Wilcox
Comment 1 2006-10-25 15:24:46 PDT
Created attachment 11214 [details] Test case Run the sample, move to middle text, press delete. When linked with TOT this test shows that the selection change editing delegate is called right after the delete editing delegate, even though NO is returned to the delete request.
Duncan Wilcox
Comment 2 2006-10-25 15:25:42 PDT
Forgot to mention this is a regression from 2.0.4/419.3
Stephanie Lewis
Comment 3 2006-11-08 15:15:09 PST
radar 4826940
Justin Garcia
Comment 4 2006-12-01 15:52:27 PST
r17981
Note You need to log in before you can comment on or make changes to this bug.