Bug 114134

Summary: [BlackBerry] Provide more specific error description for SocketStreamError
Product: WebKit Reporter: Seokju Kwon <seokju>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, joenotcharles, rwlbuis, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Seokju Kwon 2013-04-07 18:15:57 PDT 
Pass the reason of a failure to SocketStreamError instance
and notify it via SocketStreamHandleClient::didFailSocketStream().
Comment 1 Seokju Kwon 2013-04-07 18:17:14 PDT 
Created attachment 196818 [details]
Patch
Comment 2 Rob Buis 2013-04-08 07:30:02 PDT 
Comment on attachment 196818 [details]
Patch

Thanks for your contribution! I think the change is good, but can you check if you missed any instance of didFailSocketStream being called in this file? Thanks!
Comment 3 Joe Mason 2013-04-08 07:41:54 PDT 
(In reply to comment #2)
> (From update of attachment 196818 [details])
> Thanks for your contribution! I think the change is good, but can you check if you missed any instance of didFailSocketStream being called in this file? Thanks!

The only other call to didFailSocketStream is in notifyClose, which has no message param, so I think it's fine for the SocketError to use the default message-less constructor for that call.
Comment 4 Rob Buis 2013-04-08 07:53:14 PDT 
Comment on attachment 196818 [details]
Patch

Ok, after Joe's explanation, this change is fine!
Comment 5 WebKit Commit Bot 2013-04-08 08:28:35 PDT 
Comment on attachment 196818 [details]
Patch

Clearing flags on attachment: 196818

Committed r147915: <http://trac.webkit.org/changeset/147915>
Comment 6 WebKit Commit Bot 2013-04-08 08:28:37 PDT 
All reviewed patches have been landed.  Closing bug.