Bug 114132

Summary:

[WIN] Fix problems with export macros of AutodrainedPool

Product:

WebKit

Reporter:

Patrick R. Gansterer <paroga>

Component:

New Bugs

Assignee:

Patrick R. Gansterer <paroga>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ggaren: review+, ggaren: commit-queue-

Description Patrick R. Gansterer 2013-04-07 14:53:34 PDT

[WIN] Fix problems with export macros of AutodrainedPool

Comment 1 Patrick R. Gansterer 2013-04-07 14:57:03 PDT

Created attachment 196814 [details]
Patch

Comment 2 Geoffrey Garen 2013-04-07 15:46:30 PDT

Comment on attachment 196814 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196814&action=review

Please fix the style comment below before landing.

> Source/WTF/wtf/AutodrainedPool.h:49
> +    inline explicit AutodrainedPool(int = 1) { }
> +    inline ~AutodrainedPool() { }
> +    inline void cycle() { }

No need for the inline keyword when defining a function inside its class declaration -- inline is implied.

Comment 3 Patrick R. Gansterer 2013-04-07 15:59:15 PDT

Committed r147884: <http://trac.webkit.org/changeset/147884>