Bug 114119

Summary:

Remove feature: CSS variables

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

CSS

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abecsi, allan.jensen, beidson, benjamin, buildbot, cmarcelo, dbates, divya, eric, esprehn+autocc, gtk-ews, gyuyoung.kim, jon.rimmer, kling, koivisto, macpherson, menard, ojan.autocc, rakuco, rego+ews, rniwa, syoichi, vestbo, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Remove CSS variables (for EWS)	none
Remove CSS variables (for EWS)	webkit-ews: commit-queue-
I can't brain on Sundays	webkit-ews: commit-queue-
rebased patch	kling: review+

Andreas Kling

Reported 2013-04-07 09:34:59 PDT

The CSS variables feature was only shipped by Chromium and we should remove it, as it'll just start to bitrot.

Attachments
Remove CSS variables (for EWS) (100.64 KB, patch) 2013-04-07 09:56 PDT, Andreas Kling	no flags	Details Formatted Diff Diff
Remove CSS variables (for EWS) (106.66 KB, patch) 2013-04-07 09:57 PDT, Andreas Kling	webkit-ews: commit-queue-	Details Formatted Diff Diff
I can't brain on Sundays (119.13 KB, patch) 2013-04-07 12:36 PDT, Andreas Kling	webkit-ews: commit-queue-	Details Formatted Diff Diff
rebased patch (206.84 KB, patch) 2013-11-28 07:24 PST, Antti Koivisto	kling: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2013-04-07 09:53:19 PDT

<https://lists.webkit.org/pipermail/webkit-dev/2013-April/024476.html>

Andreas Kling

Comment 2 2013-04-07 09:56:17 PDT

Created attachment 196791 [details] Remove CSS variables (for EWS)

Andreas Kling

Comment 3 2013-04-07 09:57:13 PDT

Created attachment 196792 [details] Remove CSS variables (for EWS)

Early Warning System Bot

Comment 4 2013-04-07 10:05:22 PDT

Comment on attachment 196792 [details] Remove CSS variables (for EWS) Attachment 196792 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17525742

Early Warning System Bot

Comment 5 2013-04-07 10:07:19 PDT

Comment on attachment 196792 [details] Remove CSS variables (for EWS) Attachment 196792 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17540338

EFL EWS Bot

Comment 6 2013-04-07 10:25:26 PDT

Comment on attachment 196792 [details] Remove CSS variables (for EWS) Attachment 196792 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17528774

Build Bot

Comment 7 2013-04-07 10:34:46 PDT

Comment on attachment 196792 [details] Remove CSS variables (for EWS) Attachment 196792 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17446744

kov's GTK+ EWS bot

Comment 8 2013-04-07 10:44:21 PDT

Comment on attachment 196792 [details] Remove CSS variables (for EWS) Attachment 196792 [details] did not pass gtk-ews (gtk): Output: http://webkit-commit-queue.appspot.com/results/17524750

Build Bot

Comment 9 2013-04-07 10:45:39 PDT

Comment on attachment 196792 [details] Remove CSS variables (for EWS) Attachment 196792 [details] did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/17486841

Andreas Kling

Comment 10 2013-04-07 12:36:36 PDT

Created attachment 196801 [details] I can't brain on Sundays

Early Warning System Bot

Comment 11 2013-04-07 12:56:32 PDT

Comment on attachment 196801 [details] I can't brain on Sundays Attachment 196801 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17423102

Early Warning System Bot

Comment 12 2013-04-07 13:02:00 PDT

Comment on attachment 196801 [details] I can't brain on Sundays Attachment 196801 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17547013

EFL EWS Bot

Comment 13 2013-04-07 13:21:00 PDT

Comment on attachment 196801 [details] I can't brain on Sundays Attachment 196801 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17504007

Jon Rimmer

Comment 14 2013-04-07 13:25:08 PDT

As a web developer, I have to say that this is an extremely disappointing decision. Apple should be turning this feature on in their browsers, not removing it.

Build Bot

Comment 15 2013-04-07 13:30:15 PDT

Comment on attachment 196801 [details] I can't brain on Sundays Attachment 196801 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17522156

Build Bot

Comment 16 2013-04-07 14:00:48 PDT

Comment on attachment 196801 [details] I can't brain on Sundays Attachment 196801 [details] did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/17508024

Allan Sandfeld Jensen

Comment 17 2013-04-07 14:22:30 PDT

Comment on attachment 196801 [details] I can't brain on Sundays It would probably be a good idea to repeat the rationalle in the Changelog for future reference.

Andreas Kling

Comment 18 2013-04-07 14:30:47 PDT

(In reply to comment #17) > (From update of attachment 196801 [details]) > It would probably be a good idea to repeat the rationalle in the Changelog for future reference. Oh definitely. These are just my (lame) attempts at getting a green EWS before making the final patch. (In reply to comment #14) > As a web developer, I have to say that this is an extremely disappointing decision. Apple should be turning this feature on in their browsers, not removing it. Please voice your concerns on the webkit-dev mailing list by responding to this thread: <https://lists.webkit.org/pipermail/webkit-dev/2013-April/024476.html> Whether or not the feature is removed is still up for discussion. I'm just trying to be proactive here.

Build Bot

Comment 19 2013-04-07 15:13:58 PDT

Comment on attachment 196801 [details] I can't brain on Sundays Attachment 196801 [details] did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/17553004

Antti Koivisto

Comment 20 2013-11-28 07:24:05 PST

Created attachment 218002 [details] rebased patch

Andreas Kling

Comment 21 2013-11-28 07:31:58 PST

Comment on attachment 218002 [details] rebased patch r=me. Thank you for moving this forward. The code was nowhere near WebKit quality standards, and it's effectively unmaintained. There should be something about that in the ChangeLog.

Antti Koivisto

Comment 22 2013-11-28 07:44:55 PST

ttps://trac.webkit.org/r159842

Note You need to log in before you can comment on or make changes to this bug.