Summary: | [GTK][AC] Support masksToBounds for clutter AC backend. | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | ChangSeok Oh <kevin.cs.oh> | ||||||||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | commit-queue, gustavo, joone | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | 113912 | ||||||||||||||
Bug Blocks: | 105699 | ||||||||||||||
Attachments: |
|
Description
ChangSeok Oh
2013-04-07 03:46:51 PDT
Created attachment 196776 [details]
Patch
Created attachment 196782 [details]
Patch
Created attachment 196783 [details]
Patch
Applied to webkit-clutter. http://cgit.collabora.com/git/webkit-clutter.git/commit/?h=wip/changseok/unreviewed&id=f56cc09cdd1653246bc6d2f799ac774ec6d1e184 Created attachment 196795 [details]
Patch
Comment on attachment 196795 [details]
Patch
In the current implementation we do clipping at paint time, apparently because we need to take the scroll offset into consideration for the clipping, does this change work when a layer has masksToBounds and is scrolled?
(In reply to comment #6) > (From update of attachment 196795 [details]) > In the current implementation we do clipping at paint time, apparently because we need to take the scroll offset into consideration for the clipping, does this change work when a layer has masksToBounds and is scrolled? yes. it seems working without any artifacts as I know. Would you let me know any sample for the case concerned? :) Created attachment 197747 [details]
Patch
Comment on attachment 197747 [details]
Patch
Added graphicsLayerActorSetMasksToBounds in GraphicsLayerClutter::setupContentsLayer
Comment on attachment 197747 [details]
Patch
None that I know, remember to merge this one on webkit-clutter too.
Comment on attachment 197747 [details] Patch Clearing flags on attachment: 197747 Committed r148742: <http://trac.webkit.org/changeset/148742> All reviewed patches have been landed. Closing bug. (In reply to comment #10) > (From update of attachment 197747 [details]) > None that I know, remember to merge this one on webkit-clutter too. Sure. I will~ In webkit-clutter we do the clipping at paint time, I am not 100% on why, but I remember Joone explaining at some point. Merging this patch in webkit-clutter (which moved the clipping from paint time to setMasksToBounds time) broke the drawing of layers in pages such as this one: http://www.anthonycalzadilla.com/css3-ATAT/ I am still building webkit-gtk with clutter AC to test if that also happened in webkitgtk's case. Actually, this page is a better test, zooming and scrolling around should show the issue: https://developers.google.com/maps/documentation/javascript/examples/map-simple?hl=pt-br |