Bug 11411

Summary: REGRESSION (r17280): Repro crash when clicking a link with target="_blank"
Product: WebKit Reporter: mitz
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Critical Keywords: EasyFix, Regression
Priority: P1    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Fix
none
Updated based on comments
none
Once more into the breach... mitz: review+

Description mitz 2006-10-25 02:16:12 PDT
Safari crashes when you click a link with target="_blank" in a document with an http: URL. The crash is in -[WebCoreFrameBridge canTargetLoadInFrame:] due to this change in r17280:

-    WebCoreFrameBridge *parentBridge = [targetFrame parent];
+    WebCoreFrameBridge *parentBridge = Mac([targetFrame _frame]->tree()->parent())->bridge();
Comment 1 David Smith 2006-10-25 04:24:45 PDT
Created attachment 11201 [details]
Fix
Comment 2 David Smith 2006-10-25 04:40:20 PDT
Created attachment 11204 [details]
Updated based on comments
Comment 3 David Smith 2006-10-25 04:46:52 PDT
Created attachment 11205 [details]
Once more into the breach...

Silly *s, always being in the wrong place.
Comment 4 mitz 2006-10-25 04:49:08 PDT
Comment on attachment 11205 [details]
Once more into the breach...

r=me
Comment 5 Mark Rowe (bdash) 2006-10-25 05:19:10 PDT
Landed in r17288.