Summary: | Make Frame's ScriptController an OwnPtr and remove the #include | ||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||||||||||||||||||||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, dbates, philn, rniwa, webkit-ews, webkit.review.bot, xan.lopez | ||||||||||||||||||||||||||||||
Priority: | P2 | ||||||||||||||||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||||||||||||
Attachments: |
|
Description
Sam Weinig
2013-04-06 16:26:21 PDT
Created attachment 196758 [details]
Patch
Attachment 196758 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/websockets/WebSocket.cpp', u'Source/WebCore/bindings/generic/BindingSecurity.cpp', u'Source/WebCore/bindings/js/JSEventListener.cpp', u'Source/WebCore/bindings/js/JSLazyEventListener.cpp', u'Source/WebCore/bindings/js/PageScriptDebugServer.cpp', u'Source/WebCore/bindings/js/ScriptEventListener.cpp', u'Source/WebCore/bindings/js/ScriptState.cpp', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/bindings/objc/DOMAbstractView.mm', u'Source/WebCore/bindings/objc/DOMInternal.mm', u'Source/WebCore/dom/DocumentStyleSheetCollection.cpp', u'Source/WebCore/dom/EventTarget.cpp', u'Source/WebCore/dom/ScriptElement.cpp', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/html/HTMLCanvasElement.cpp', u'Source/WebCore/html/HTMLDocument.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLFormElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/html/parser/HTMLParserOptions.cpp', u'Source/WebCore/inspector/InspectorAgent.cpp', u'Source/WebCore/inspector/InspectorController.cpp', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.cpp', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/PageRuntimeAgent.cpp', u'Source/WebCore/loader/DocumentWriter.cpp', u'Source/WebCore/loader/NavigationScheduler.cpp', u'Source/WebCore/loader/SubframeLoader.cpp', u'Source/WebCore/loader/cache/CachedResourceLoader.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/EventSource.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/Navigator.cpp', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/PageGroup.cpp', u'Source/WebCore/xml/XMLHttpRequest.cpp', u'Source/WebCore/xml/XMLTreeViewer.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/Plugins/Hosted/HostedNetscapePluginStream.mm', u'Source/WebKit/mac/Plugins/WebNetscapePluginStream.mm', u'Source/WebKit/mac/Plugins/WebPluginContainerCheck.mm', u'Source/WebKit/mac/WebCoreSupport/WebGeolocationClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/WebHitTestResult.cpp', u'Source/WebKit2/Shared/WebHitTestResult.h', u'Source/WebKit2/UIProcess/WebContext.h', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp', u'Source/WebKit2/WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp', u'Source/WebKit2/WebProcess/Plugins/PDF/SimplePDFPlugin.h', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/Storage/StorageAreaProxy.cpp', u'Source/WebKit2/WebProcess/WebPage/WebFrame.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp']" exit_code: 1
Source/WebCore/page/Frame.cpp:82: "ScriptController.h" already included at Source/WebCore/page/Frame.cpp:81 [build/include] [4]
Source/WebCore/inspector/InspectorInstrumentation.cpp:71: Alphabetical sorting problem. [build/include_order] [4]
Source/WebKit2/WebProcess/Storage/StorageAreaProxy.cpp:35: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 3 in 63 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 196758 [details] Patch Attachment 196758 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17473850 Created attachment 196759 [details]
Patch
The intent of this patch is to work towards reducing the cost of #including Frame.h, which is currently very high. By itself, this does not seem to have much benefit, but combined with other reductions (such as making ScriptWrappable not include so much of JSC and removing a few other Frame.h #includes) it should be quite nice. Comment on attachment 196759 [details] Patch Attachment 196759 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17524516 Created attachment 196760 [details]
Patch
Comment on attachment 196760 [details] Patch Attachment 196760 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17446527 Comment on attachment 196760 [details] Patch Attachment 196760 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17529523 Created attachment 196761 [details]
Patch
Comment on attachment 196761 [details] Patch Attachment 196761 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17446529 Comment on attachment 196761 [details] Patch Attachment 196761 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17528534 Comment on attachment 196761 [details] Patch Attachment 196761 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17446590 Comment on attachment 196761 [details]
Patch
Nice!
As implied by the EFL and GTK EWS error output, you'll need to include the header Document.h in file Source/WebCore/editing/atk/FrameSelectionAtk.cpp because you removed the include header ScriptController.h from file Source/WebCore/page/Frame.h.
Additionally, you'll need to include the header ScriptController.h in file Source/WebKit/qt/Api/qwebelement.cpp as implied by the error output from the Qt- and Qt-WK2- EWS bots.
Comment on attachment 196761 [details] Patch Attachment 196761 [details] did not pass win-ews (win): Output: http://webkit-commit-queue.appspot.com/results/17605020 Created attachment 197391 [details]
Patch
Comment on attachment 197391 [details] Patch Attachment 197391 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17598063 Comment on attachment 197391 [details] Patch Attachment 197391 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17644036 Comment on attachment 197391 [details] Patch Attachment 197391 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17626035 Comment on attachment 197391 [details] Patch Attachment 197391 [details] did not pass win-ews (win): Output: http://webkit-commit-queue.appspot.com/results/17641051 Created attachment 197399 [details]
Patch
Comment on attachment 197399 [details] Patch Attachment 197399 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17748006 Comment on attachment 197399 [details] Patch Attachment 197399 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17748007 Comment on attachment 197399 [details] Patch Attachment 197399 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17592069 Comment on attachment 197399 [details] Patch Attachment 197399 [details] did not pass win-ews (win): Output: http://webkit-commit-queue.appspot.com/results/17611106 Comment on attachment 197399 [details] Patch Attachment 197399 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17716094 Comment on attachment 197399 [details] Patch Attachment 197399 [details] did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/17736054 Created attachment 197866 [details]
Patch
Comment on attachment 197866 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197866&action=review > Source/WebCore/page/Frame.cpp:154 > - , m_script(this) > + , m_script(adoptPtr(new ScriptController(this))) Why don't we add ScriptController::create? Attachment 197866 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/networkinfo/NetworkInfoConnection.cpp', u'Source/WebCore/Modules/websockets/WebSocket.cpp', u'Source/WebCore/bindings/generic/BindingSecurity.cpp', u'Source/WebCore/bindings/js/JSEventListener.cpp', u'Source/WebCore/bindings/js/JSLazyEventListener.cpp', u'Source/WebCore/bindings/js/PageScriptDebugServer.cpp', u'Source/WebCore/bindings/js/ScriptEventListener.cpp', u'Source/WebCore/bindings/js/ScriptState.cpp', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/bindings/objc/DOMAbstractView.mm', u'Source/WebCore/bindings/objc/DOMInternal.mm', u'Source/WebCore/dom/DocumentStyleSheetCollection.cpp', u'Source/WebCore/dom/EventTarget.cpp', u'Source/WebCore/dom/ScriptElement.cpp', u'Source/WebCore/editing/atk/FrameSelectionAtk.cpp', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/html/HTMLCanvasElement.cpp', u'Source/WebCore/html/HTMLDocument.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLFormElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/html/parser/HTMLParserOptions.cpp', u'Source/WebCore/html/parser/XSSAuditorDelegate.cpp', u'Source/WebCore/inspector/InspectorAgent.cpp', u'Source/WebCore/inspector/InspectorController.cpp', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.cpp', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/PageRuntimeAgent.cpp', u'Source/WebCore/loader/DocumentWriter.cpp', u'Source/WebCore/loader/NavigationScheduler.cpp', u'Source/WebCore/loader/SubframeLoader.cpp', u'Source/WebCore/loader/cache/CachedResourceLoader.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/EventSource.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/Navigator.cpp', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/PageGroup.cpp', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm', u'Source/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp', u'Source/WebCore/plugins/PluginView.cpp', u'Source/WebCore/plugins/gtk/PluginViewGtk.cpp', u'Source/WebCore/plugins/qt/PluginViewQt.cpp', u'Source/WebCore/xml/XMLHttpRequest.cpp', u'Source/WebCore/xml/XMLTreeViewer.cpp', u'Source/WebKit/gtk/webkit/webkitviewportattributes.cpp', u'Source/WebKit/gtk/webkit/webkitwebview.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/Plugins/Hosted/HostedNetscapePluginStream.mm', u'Source/WebKit/mac/Plugins/WebNetscapePluginStream.mm', u'Source/WebKit/mac/Plugins/WebPluginContainerCheck.mm', u'Source/WebKit/mac/WebCoreSupport/WebGeolocationClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/qt/Api/qwebelement.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/WebHitTestResult.cpp', u'Source/WebKit2/Shared/WebHitTestResult.h', u'Source/WebKit2/UIProcess/Plugins/PlugInAutoStartProvider.cpp', u'Source/WebKit2/UIProcess/WebContext.h', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp', u'Source/WebKit2/WebProcess/Plugins/Netscape/NPJSObject.cpp', u'Source/WebKit2/WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp', u'Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/Storage/StorageAreaImpl.cpp', u'Source/WebKit2/WebProcess/Storage/StorageAreaMap.cpp', u'Source/WebKit2/WebProcess/WebPage/WebFrame.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp']" exit_code: 1
Source/WebKit2/WebProcess/Storage/StorageAreaImpl.cpp:31: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 78 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 197866 [details] Patch Attachment 197866 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/6070 Comment on attachment 197866 [details] Patch Attachment 197866 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/57197 Comment on attachment 197866 [details] Patch Attachment 197866 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-queues.appspot.com/results/83283 Comment on attachment 197866 [details] Patch Attachment 197866 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/131088 Comment on attachment 197866 [details] Patch Attachment 197866 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/83284 Comment on attachment 197866 [details] Patch Attachment 197866 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/12096 Created attachment 197882 [details]
Patch
Comment on attachment 197882 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197882&action=review > Source/WebKit2/Shared/WebHitTestResult.cpp:29 > +#include <WebCore/KURL.h> > #include <WebCore/KURL.h> duplicate > Source/WebKit2/Shared/WebHitTestResult.h:24 > -#include <WebCore/FrameView.h> > -#include <WebCore/HitTestResult.h> > -#include <WebCore/KURL.h> > -#include <WebCore/Node.h> > +#include <WebCore/IntRect.h> Is this part of the ScriptController.h change, or just a separate good change? Attachment 197882 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/networkinfo/NetworkInfoConnection.cpp', u'Source/WebCore/Modules/websockets/WebSocket.cpp', u'Source/WebCore/bindings/generic/BindingSecurity.cpp', u'Source/WebCore/bindings/js/JSEventListener.cpp', u'Source/WebCore/bindings/js/JSLazyEventListener.cpp', u'Source/WebCore/bindings/js/PageScriptDebugServer.cpp', u'Source/WebCore/bindings/js/ScriptEventListener.cpp', u'Source/WebCore/bindings/js/ScriptState.cpp', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/bindings/objc/DOMAbstractView.mm', u'Source/WebCore/bindings/objc/DOMInternal.mm', u'Source/WebCore/dom/DocumentStyleSheetCollection.cpp', u'Source/WebCore/dom/EventTarget.cpp', u'Source/WebCore/dom/ScriptElement.cpp', u'Source/WebCore/editing/atk/FrameSelectionAtk.cpp', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/html/HTMLCanvasElement.cpp', u'Source/WebCore/html/HTMLDocument.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLFormElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/html/parser/HTMLParserOptions.cpp', u'Source/WebCore/html/parser/XSSAuditorDelegate.cpp', u'Source/WebCore/inspector/InspectorAgent.cpp', u'Source/WebCore/inspector/InspectorController.cpp', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.cpp', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/PageRuntimeAgent.cpp', u'Source/WebCore/loader/DocumentWriter.cpp', u'Source/WebCore/loader/NavigationScheduler.cpp', u'Source/WebCore/loader/SubframeLoader.cpp', u'Source/WebCore/loader/cache/CachedResourceLoader.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/EventSource.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/Navigator.cpp', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/PageGroup.cpp', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm', u'Source/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp', u'Source/WebCore/plugins/PluginView.cpp', u'Source/WebCore/plugins/gtk/PluginViewGtk.cpp', u'Source/WebCore/plugins/qt/PluginViewQt.cpp', u'Source/WebCore/xml/XMLHttpRequest.cpp', u'Source/WebCore/xml/XMLTreeViewer.cpp', u'Source/WebKit/gtk/webkit/webkitviewportattributes.cpp', u'Source/WebKit/gtk/webkit/webkitwebview.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/Plugins/Hosted/HostedNetscapePluginStream.mm', u'Source/WebKit/mac/Plugins/WebNetscapePluginStream.mm', u'Source/WebKit/mac/Plugins/WebPluginContainerCheck.mm', u'Source/WebKit/mac/WebCoreSupport/WebGeolocationClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/qt/Api/qwebelement.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/WebHitTestResult.cpp', u'Source/WebKit2/Shared/WebHitTestResult.h', u'Source/WebKit2/UIProcess/Plugins/PlugInAutoStartProvider.cpp', u'Source/WebKit2/UIProcess/WebContext.h', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp', u'Source/WebKit2/WebProcess/Plugins/Netscape/NPJSObject.cpp', u'Source/WebKit2/WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp', u'Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/Storage/StorageAreaImpl.cpp', u'Source/WebKit2/WebProcess/Storage/StorageAreaMap.cpp', u'Source/WebKit2/WebProcess/WebPage/WebFrame.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp']" exit_code: 1
Source/WebKit2/WebProcess/Storage/StorageAreaImpl.cpp:31: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 78 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 197882 [details] Patch Attachment 197882 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/7300 Comment on attachment 197882 [details] Patch Attachment 197882 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-queues.appspot.com/results/131143 Created attachment 197885 [details]
Patch
Attachment 197885 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/networkinfo/NetworkInfoConnection.cpp', u'Source/WebCore/Modules/websockets/WebSocket.cpp', u'Source/WebCore/bindings/generic/BindingSecurity.cpp', u'Source/WebCore/bindings/js/JSEventListener.cpp', u'Source/WebCore/bindings/js/JSLazyEventListener.cpp', u'Source/WebCore/bindings/js/PageScriptDebugServer.cpp', u'Source/WebCore/bindings/js/ScriptEventListener.cpp', u'Source/WebCore/bindings/js/ScriptState.cpp', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/bindings/objc/DOMAbstractView.mm', u'Source/WebCore/bindings/objc/DOMInternal.mm', u'Source/WebCore/dom/DocumentStyleSheetCollection.cpp', u'Source/WebCore/dom/EventTarget.cpp', u'Source/WebCore/dom/ScriptElement.cpp', u'Source/WebCore/editing/atk/FrameSelectionAtk.cpp', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/html/HTMLCanvasElement.cpp', u'Source/WebCore/html/HTMLDocument.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLFormElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/html/parser/HTMLParserOptions.cpp', u'Source/WebCore/html/parser/XSSAuditorDelegate.cpp', u'Source/WebCore/inspector/InspectorAgent.cpp', u'Source/WebCore/inspector/InspectorController.cpp', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.cpp', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/PageRuntimeAgent.cpp', u'Source/WebCore/loader/DocumentWriter.cpp', u'Source/WebCore/loader/NavigationScheduler.cpp', u'Source/WebCore/loader/SubframeLoader.cpp', u'Source/WebCore/loader/cache/CachedResourceLoader.cpp', u'Source/WebCore/page/BarInfo.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/EventSource.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/Navigator.cpp', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/PageGroup.cpp', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm', u'Source/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp', u'Source/WebCore/plugins/PluginView.cpp', u'Source/WebCore/plugins/efl/PluginViewEfl.cpp', u'Source/WebCore/plugins/gtk/PluginViewGtk.cpp', u'Source/WebCore/plugins/qt/PluginViewQt.cpp', u'Source/WebCore/xml/XMLHttpRequest.cpp', u'Source/WebCore/xml/XMLTreeViewer.cpp', u'Source/WebKit/gtk/webkit/webkitviewportattributes.cpp', u'Source/WebKit/gtk/webkit/webkitwebview.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/Plugins/Hosted/HostedNetscapePluginStream.mm', u'Source/WebKit/mac/Plugins/WebNetscapePluginStream.mm', u'Source/WebKit/mac/Plugins/WebPluginContainerCheck.mm', u'Source/WebKit/mac/WebCoreSupport/WebGeolocationClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/qt/Api/qwebelement.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/WebHitTestResult.cpp', u'Source/WebKit2/Shared/WebHitTestResult.h', u'Source/WebKit2/UIProcess/Plugins/PlugInAutoStartProvider.cpp', u'Source/WebKit2/UIProcess/WebContext.h', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp', u'Source/WebKit2/WebProcess/Plugins/Netscape/NPJSObject.cpp', u'Source/WebKit2/WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp', u'Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/Storage/StorageAreaImpl.cpp', u'Source/WebKit2/WebProcess/Storage/StorageAreaMap.cpp', u'Source/WebKit2/WebProcess/WebPage/WebFrame.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp']" exit_code: 1
Source/WebKit2/WebProcess/Storage/StorageAreaImpl.cpp:31: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 80 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 197885 [details] Patch Attachment 197885 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/6118 Comment on attachment 197885 [details] Patch Attachment 197885 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/35372 Comment on attachment 197885 [details] Patch Attachment 197885 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-queues.appspot.com/results/139137 Created attachment 197890 [details]
Patch
Attachment 197890 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/networkinfo/NetworkInfoConnection.cpp', u'Source/WebCore/Modules/websockets/WebSocket.cpp', u'Source/WebCore/bindings/generic/BindingSecurity.cpp', u'Source/WebCore/bindings/js/JSEventListener.cpp', u'Source/WebCore/bindings/js/JSLazyEventListener.cpp', u'Source/WebCore/bindings/js/PageScriptDebugServer.cpp', u'Source/WebCore/bindings/js/ScriptEventListener.cpp', u'Source/WebCore/bindings/js/ScriptState.cpp', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/bindings/objc/DOMAbstractView.mm', u'Source/WebCore/bindings/objc/DOMInternal.mm', u'Source/WebCore/dom/DocumentStyleSheetCollection.cpp', u'Source/WebCore/dom/EventTarget.cpp', u'Source/WebCore/dom/ScriptElement.cpp', u'Source/WebCore/editing/atk/FrameSelectionAtk.cpp', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/html/HTMLCanvasElement.cpp', u'Source/WebCore/html/HTMLDocument.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLFormElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/html/parser/HTMLParserOptions.cpp', u'Source/WebCore/html/parser/XSSAuditorDelegate.cpp', u'Source/WebCore/inspector/InspectorAgent.cpp', u'Source/WebCore/inspector/InspectorController.cpp', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.cpp', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/PageRuntimeAgent.cpp', u'Source/WebCore/loader/DocumentWriter.cpp', u'Source/WebCore/loader/NavigationScheduler.cpp', u'Source/WebCore/loader/SubframeLoader.cpp', u'Source/WebCore/loader/cache/CachedResourceLoader.cpp', u'Source/WebCore/page/BarInfo.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/EventSource.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/Navigator.cpp', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/PageGroup.cpp', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm', u'Source/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp', u'Source/WebCore/plugins/PluginView.cpp', u'Source/WebCore/plugins/efl/PluginViewEfl.cpp', u'Source/WebCore/plugins/gtk/PluginViewGtk.cpp', u'Source/WebCore/plugins/qt/PluginViewQt.cpp', u'Source/WebCore/xml/XMLHttpRequest.cpp', u'Source/WebCore/xml/XMLTreeViewer.cpp', u'Source/WebKit/gtk/webkit/webkitviewportattributes.cpp', u'Source/WebKit/gtk/webkit/webkitwebview.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/Plugins/Hosted/HostedNetscapePluginStream.mm', u'Source/WebKit/mac/Plugins/WebNetscapePluginStream.mm', u'Source/WebKit/mac/Plugins/WebPluginContainerCheck.mm', u'Source/WebKit/mac/WebCoreSupport/WebGeolocationClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/qt/Api/qwebelement.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp', u'Source/WebKit/win/WebCoreSupport/WebGeolocationClient.cpp', u'Source/WebKit/win/WebView.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/WebHitTestResult.cpp', u'Source/WebKit2/Shared/WebHitTestResult.h', u'Source/WebKit2/UIProcess/Plugins/PlugInAutoStartProvider.cpp', u'Source/WebKit2/UIProcess/WebContext.h', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp', u'Source/WebKit2/WebProcess/Plugins/Netscape/NPJSObject.cpp', u'Source/WebKit2/WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp', u'Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/Storage/StorageAreaImpl.cpp', u'Source/WebKit2/WebProcess/Storage/StorageAreaMap.cpp', u'Source/WebKit2/WebProcess/WebPage/WebFrame.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp']" exit_code: 1
Source/WebKit2/WebProcess/Storage/StorageAreaImpl.cpp:31: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 82 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 197890 [details] Patch Attachment 197890 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/6125 Comment on attachment 197890 [details] Patch Attachment 197890 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/7316 Created attachment 197891 [details]
Patch
Attachment 197891 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/networkinfo/NetworkInfoConnection.cpp', u'Source/WebCore/Modules/websockets/WebSocket.cpp', u'Source/WebCore/bindings/generic/BindingSecurity.cpp', u'Source/WebCore/bindings/js/JSEventListener.cpp', u'Source/WebCore/bindings/js/JSLazyEventListener.cpp', u'Source/WebCore/bindings/js/PageScriptDebugServer.cpp', u'Source/WebCore/bindings/js/ScriptEventListener.cpp', u'Source/WebCore/bindings/js/ScriptState.cpp', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/bindings/objc/DOMAbstractView.mm', u'Source/WebCore/bindings/objc/DOMInternal.mm', u'Source/WebCore/dom/DocumentStyleSheetCollection.cpp', u'Source/WebCore/dom/EventTarget.cpp', u'Source/WebCore/dom/ScriptElement.cpp', u'Source/WebCore/editing/atk/FrameSelectionAtk.cpp', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/html/HTMLCanvasElement.cpp', u'Source/WebCore/html/HTMLDocument.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLFormElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/html/parser/HTMLParserOptions.cpp', u'Source/WebCore/html/parser/XSSAuditorDelegate.cpp', u'Source/WebCore/inspector/InspectorAgent.cpp', u'Source/WebCore/inspector/InspectorController.cpp', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.cpp', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/PageRuntimeAgent.cpp', u'Source/WebCore/loader/DocumentWriter.cpp', u'Source/WebCore/loader/NavigationScheduler.cpp', u'Source/WebCore/loader/SubframeLoader.cpp', u'Source/WebCore/loader/cache/CachedResourceLoader.cpp', u'Source/WebCore/page/BarInfo.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/EventSource.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/Navigator.cpp', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/PageGroup.cpp', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm', u'Source/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp', u'Source/WebCore/plugins/DOMMimeTypeArray.cpp', u'Source/WebCore/plugins/DOMPlugin.cpp', u'Source/WebCore/plugins/DOMPluginArray.cpp', u'Source/WebCore/plugins/PluginView.cpp', u'Source/WebCore/plugins/efl/PluginViewEfl.cpp', u'Source/WebCore/plugins/gtk/PluginViewGtk.cpp', u'Source/WebCore/plugins/qt/PluginViewQt.cpp', u'Source/WebCore/storage/Storage.cpp', u'Source/WebCore/xml/XMLHttpRequest.cpp', u'Source/WebCore/xml/XMLTreeViewer.cpp', u'Source/WebKit/gtk/webkit/webkitviewportattributes.cpp', u'Source/WebKit/gtk/webkit/webkitwebview.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/Plugins/Hosted/HostedNetscapePluginStream.mm', u'Source/WebKit/mac/Plugins/WebNetscapePluginStream.mm', u'Source/WebKit/mac/Plugins/WebPluginContainerCheck.mm', u'Source/WebKit/mac/WebCoreSupport/WebGeolocationClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/qt/Api/qwebelement.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp', u'Source/WebKit/win/WebCoreSupport/WebGeolocationClient.cpp', u'Source/WebKit/win/WebView.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/WebHitTestResult.cpp', u'Source/WebKit2/Shared/WebHitTestResult.h', u'Source/WebKit2/UIProcess/Plugins/PlugInAutoStartProvider.cpp', u'Source/WebKit2/UIProcess/WebContext.h', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp', u'Source/WebKit2/WebProcess/Plugins/Netscape/NPJSObject.cpp', u'Source/WebKit2/WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp', u'Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/Storage/StorageAreaImpl.cpp', u'Source/WebKit2/WebProcess/Storage/StorageAreaMap.cpp', u'Source/WebKit2/WebProcess/WebPage/WebFrame.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp']" exit_code: 1
Source/WebKit2/WebProcess/Storage/StorageAreaImpl.cpp:31: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 86 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 197891 [details] Patch Attachment 197891 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/94042 Comment on attachment 197891 [details] Patch Attachment 197891 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/9024 Comment on attachment 197891 [details] Patch Attachment 197891 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-queues.appspot.com/results/143004 Comment on attachment 197891 [details] Patch Attachment 197891 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/52090 Comment on attachment 197891 [details] Patch Attachment 197891 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/24011 Created attachment 197954 [details]
Patch
Comment on attachment 197954 [details] Patch Attachment 197954 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/102254 Comment on attachment 197954 [details] Patch Attachment 197954 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/113193 Comment on attachment 197954 [details] Patch Attachment 197954 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/143228 Comment on attachment 197954 [details] Patch Attachment 197954 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/2434 Comment on attachment 197954 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197954&action=review > Source/WebKit2/Shared/WebHitTestResult.cpp:28 > +#include <WebCore/KURL.h> Nit: This line is unnecessary as we already include the header WebCore/KURL.h (below). Created attachment 197963 [details]
Patch
Comment on attachment 197963 [details] Patch Attachment 197963 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/102297 Comment on attachment 197963 [details] Patch Attachment 197963 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/153105 Created attachment 197964 [details]
Patch
Attachment 197964 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/networkinfo/NetworkInfoConnection.cpp', u'Source/WebCore/Modules/websockets/WebSocket.cpp', u'Source/WebCore/bindings/generic/BindingSecurity.cpp', u'Source/WebCore/bindings/js/JSEventListener.cpp', u'Source/WebCore/bindings/js/JSLazyEventListener.cpp', u'Source/WebCore/bindings/js/PageScriptDebugServer.cpp', u'Source/WebCore/bindings/js/ScriptEventListener.cpp', u'Source/WebCore/bindings/js/ScriptState.cpp', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/bindings/objc/DOMAbstractView.mm', u'Source/WebCore/bindings/objc/DOMInternal.mm', u'Source/WebCore/dom/Clipboard.cpp', u'Source/WebCore/dom/DocumentStyleSheetCollection.cpp', u'Source/WebCore/dom/EventTarget.cpp', u'Source/WebCore/dom/ScriptElement.cpp', u'Source/WebCore/editing/atk/FrameSelectionAtk.cpp', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/html/HTMLCanvasElement.cpp', u'Source/WebCore/html/HTMLDocument.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLFormElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/html/parser/HTMLParserOptions.cpp', u'Source/WebCore/html/parser/XSSAuditorDelegate.cpp', u'Source/WebCore/inspector/InspectorAgent.cpp', u'Source/WebCore/inspector/InspectorController.cpp', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.cpp', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/PageRuntimeAgent.cpp', u'Source/WebCore/loader/DocumentWriter.cpp', u'Source/WebCore/loader/NavigationScheduler.cpp', u'Source/WebCore/loader/SubframeLoader.cpp', u'Source/WebCore/loader/cache/CachedResourceLoader.cpp', u'Source/WebCore/page/BarInfo.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/EventSource.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/Navigator.cpp', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/PageGroup.cpp', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm', u'Source/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp', u'Source/WebCore/plugins/DOMMimeTypeArray.cpp', u'Source/WebCore/plugins/DOMPlugin.cpp', u'Source/WebCore/plugins/DOMPluginArray.cpp', u'Source/WebCore/plugins/PluginView.cpp', u'Source/WebCore/plugins/efl/PluginViewEfl.cpp', u'Source/WebCore/plugins/gtk/PluginViewGtk.cpp', u'Source/WebCore/plugins/qt/PluginViewQt.cpp', u'Source/WebCore/storage/Storage.cpp', u'Source/WebCore/xml/XMLHttpRequest.cpp', u'Source/WebCore/xml/XMLTreeViewer.cpp', u'Source/WebKit/gtk/webkit/webkitviewportattributes.cpp', u'Source/WebKit/gtk/webkit/webkitwebview.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/Plugins/Hosted/HostedNetscapePluginStream.mm', u'Source/WebKit/mac/Plugins/WebNetscapePluginStream.mm', u'Source/WebKit/mac/Plugins/WebPluginContainerCheck.mm', u'Source/WebKit/mac/WebCoreSupport/WebGeolocationClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/qt/Api/qwebelement.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp', u'Source/WebKit/qt/WidgetApi/qwebframe.cpp', u'Source/WebKit/win/WebCoreSupport/WebGeolocationClient.cpp', u'Source/WebKit/win/WebView.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/WebHitTestResult.cpp', u'Source/WebKit2/Shared/WebHitTestResult.h', u'Source/WebKit2/UIProcess/Plugins/PlugInAutoStartProvider.cpp', u'Source/WebKit2/UIProcess/WebContext.h', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp', u'Source/WebKit2/WebProcess/Plugins/Netscape/NPJSObject.cpp', u'Source/WebKit2/WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp', u'Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/Storage/StorageAreaImpl.cpp', u'Source/WebKit2/WebProcess/Storage/StorageAreaMap.cpp', u'Source/WebKit2/WebProcess/WebPage/WebFrame.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp']" exit_code: 1
Source/WebKit/qt/WidgetApi/qwebframe.cpp:32: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 88 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 197964 [details] Patch Attachment 197964 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/95342 Committed r148373: <http://trac.webkit.org/changeset/148373> 3 XHR tests started crashing after this patch: http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r148373%20(8844)/results.html Fixed in http://trac.webkit.org/changeset/148380. |