Bug 114019

Summary: [GTK][AC] Implement GraphicsLayerClutter::moveOrCopyAnimations
Product: WebKit Reporter: ChangSeok Oh <kevin.cs.oh>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gustavo, joone
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 105699    
Attachments:
Description Flags
Patch
gustavo: review+, gustavo: commit-queue-
Patch none

ChangSeok Oh
Reported 2013-04-05 03:28:47 PDT
In here, we fill a not implemented function of GraphicsLayerClutter::moveOrCopyAnimations.
Attachments
Patch (4.33 KB, patch)
2013-04-05 03:47 PDT, ChangSeok Oh 		gustavo: review+
gustavo: commit-queue-
DetailsFormatted DiffDiff
Patch (4.54 KB, patch)
2013-04-11 11:03 PDT, ChangSeok Oh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
ChangSeok Oh
Comment 1 2013-04-05 03:47:37 PDT
Created attachment 196612 [details] Patch
ChangSeok Oh
Comment 2 2013-04-05 04:01:03 PDT
This change already applied to webkit-clutter.
Gustavo Noronha (kov)
Comment 3 2013-04-09 05:38:01 PDT
Comment on attachment 196612 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196612&action=review > Source/WebCore/ChangeLog:10 > + Covered by existing AC animation tests. Can you specify what test(s) covers this?
ChangSeok Oh
Comment 4 2013-04-09 09:04:41 PDT
(In reply to comment #3) > (From update of attachment 196612 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=196612&action=review > > > Source/WebCore/ChangeLog:10 > > + Covered by existing AC animation tests. > > Can you specify what test(s) covers this? Hm.. it's hard to choose a specific test for only this API. But many tests related animation and compositing call this function. For instance.. LayoutTests/animations/3d/change-transform-in-end-event.html LayoutTests/animations/3d/transform-origin-vs-functions.html LayoutTests/compositing/animation/state-at-end-event-transform-layer.html
Gustavo Noronha (kov)
Comment 5 2013-04-11 07:48:24 PDT
Comment on attachment 196612 [details] Patch OK, just add some as examples to the changelog, please =)
ChangSeok Oh
Comment 6 2013-04-11 11:03:04 PDT
Created attachment 197643 [details] Patch
WebKit Commit Bot
Comment 7 2013-04-11 13:50:23 PDT
Comment on attachment 197643 [details] Patch Clearing flags on attachment: 197643 Committed r148232: <http://trac.webkit.org/changeset/148232>
Note You need to log in before you can comment on or make changes to this bug.