Bug 113991

Summary:

Web Inspector: crash in InspectorDOMAgent::innerHighlightQuad after r147566

Product:

WebKit

Reporter:

Seokju Kwon <seokju>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, commit-queue, graouts, joepeck, keishi, loislo, pfeldman, pmuellr, timothy, vsevik, web-inspector-bugs, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none

Seokju Kwon

Reported 2013-04-04 20:18:59 PDT

#0 0x00007ffff4ecbe81 in WebCore::InspectorDOMAgent::innerHighlightQuad(WTF::PassOwnPtr<WebCore::FloatQuad>, WTF::RefPtr<WebCore::InspectorObject> const*, WTF::RefPtr<WebCore::InspectorObject> const*, bool const*) () from /home/neocrash/git/WebKit/WebKitBuild/Release/lib/libwebcore_efl.so.0 #1 0x00007ffff4ecc2f5 in WebCore::InspectorDOMAgent::highlightQuad(WTF::String*, WTF::RefPtr<WebCore::InspectorArray> const&, WTF::RefPtr<WebCore::InspectorObject> const*, WTF::RefPtr<WebCore::InspectorObject> const*, bool const*) () from /home/neocrash/git/WebKit/WebKitBuild/Release/lib/libwebcore_efl.so.0 #2 0x00007ffff5ce1760 in WebCore::InspectorBackendDispatcherImpl::DOM_highlightQuad(long, WebCore::InspectorObject*) () from /home/neocrash/git/WebKit/WebKitBuild/Release/lib/libwebcore_efl.so.0 #3 0x00007ffff5d01832 in WebCore::InspectorBackendDispatcherImpl::dispatch(WTF::String const&) () from /home/neocrash/git/WebKit/WebKitBuild/Release/lib/libwebcore_efl.so.0 #4 0x00007ffff4eef5b6 in WebCore::InspectorBackendDispatchTask::onTimer(WebCore::Timer<WebCore::InspectorBackendDispatchTask>*) () from /home/neocrash/git/WebKit/WebKitBuild/Release/lib/libwebcore_efl.so.0 #5 0x00007ffff50df962 in WebCore::ThreadTimers::sharedTimerFiredInternal() () from /home/neocrash/git/WebKit/WebKitBuild/Release/lib/libwebcore_efl.so.0 #6 0x00007ffff5c6e99d in WebCore::timerEvent(void*) () from /home/neocrash/git/WebKit/WebKitBuild/Release/lib/libwebcore_efl.so.0 #7 0x00007ffff763b3de in _ecore_call_task_cb (data=<optimized out>, func=<optimized out>) at ecore_private.h:267 #8 _ecore_timer_expired_call (when=<optimized out>) at ecore_timer.c:792 #9 0x00007ffff763b5ab in _ecore_timer_expired_timers_call (when=9640.3891623) at ecore_timer.c:746 #10 0x00007ffff76384b1 in _ecore_main_loop_iterate_internal (once_only=0) at ecore_main.c:1813 #11 0x00007ffff7638b47 in ecore_main_loop_begin () at ecore_main.c:956 #12 0x0000000000403b85 in main ()

Attachments
Patch (1.59 KB, patch) 2013-04-04 20:21 PDT, Seokju Kwon	no flags	Details Formatted Diff Diff
Patch (1.52 KB, patch) 2013-04-05 01:37 PDT, Seokju Kwon	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Seokju Kwon

Comment 1 2013-04-04 20:21:47 PDT

Created attachment 196571 [details] Patch

Joseph Pecoraro

Comment 2 2013-04-05 01:24:09 PDT

Comment on attachment 196571 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196571&action=review This looked suspicious to me in earlier previous patch, but I wasn't the reviewer there. This looks good to me. r=me > Source/WebCore/ChangeLog:8 > + No new tests, covered by existing tests. Covered by existing tests? Which test is crashing? Call it out directly. If there is no test, remove this line.

Seokju Kwon

Comment 3 2013-04-05 01:37:23 PDT

Created attachment 196598 [details] Patch

WebKit Commit Bot

Comment 4 2013-04-05 02:27:01 PDT

Comment on attachment 196598 [details] Patch Clearing flags on attachment: 196598 Committed r147732: <http://trac.webkit.org/changeset/147732>

WebKit Commit Bot

Comment 5 2013-04-05 02:27:04 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.