Summary: | Add SPI to get a copy of the context menu at a given point. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
Component: | WebKit2 | Assignee: | Brady Eidson <beidson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, ap, sam | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Brady Eidson
2013-04-04 13:59:03 PDT
Created attachment 196525 [details]
Patch v1 - First swipe
Comment on attachment 196525 [details] Patch v1 - First swipe View in context: https://bugs.webkit.org/attachment.cgi?id=196525&action=review r=me with a comment > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:81 > +WK_EXPORT WKArrayRef WKBundlePageCopyContextMenuAtPoint(WKBundlePageRef, WKPoint); We should be clear what coordinate space we expect the point to be in, since your code in WebPage::contextMenuAtPoint() creates a mouse event assuming screen coordinate space. We decided on WKBundlePageCopyContextMenuAtPointOnScreen() over IRC. |