Bug 113957

Summary: [BlackBerry] Adjust fatfinger result priority.
Product: WebKit Reporter: Tiancheng Jiang <tijiang>
Component: UI EventsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, commit-queue, mifenton, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
test page
none
Patch none

Description Tiancheng Jiang 2013-04-04 13:44:00 PDT 
A clickable element should have higher priority than its parent anchor.
Comment 1 Tiancheng Jiang 2013-04-04 13:44:49 PDT 
Created attachment 196518 [details]
test page
Comment 2 Tiancheng Jiang 2013-04-04 13:50:08 PDT 
Created attachment 196520 [details]
Patch
Comment 3 Rob Buis 2013-04-04 13:58:35 PDT 
Comment on attachment 196520 [details]
Patch

Ok.
Comment 4 WebKit Commit Bot 2013-04-04 17:24:50 PDT 
Comment on attachment 196520 [details]
Patch

Clearing flags on attachment: 196520

Committed r147687: <http://trac.webkit.org/changeset/147687>
Comment 5 WebKit Commit Bot 2013-04-04 17:24:53 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Antonio Gomes 2013-04-07 09:16:19 PDT 
Comment on attachment 196520 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196520&action=review

> Source/WebKit/blackberry/ChangeLog:13
> +
> +        RIM PR 224781
> +        Internally Reviewed by Genevieve Mak.
> +
> +        Change fatfigner algorithm, return the clickable element rather than
> +        its parent anchor. Modify taphighlight and context menu node selection
> +        accordingly.

It should really mention what it fixes in real world.

> Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp:166
> +    const HitTestResult& hitResult = m_webPage->hitTestResult(m_contentPos);

Do you still have phases in FatFinger? The 'cached' results, was to avoid hit testing again, and saving up to .3s for some websites.

> Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp:171
> +    Element* elementUnderPoint = static_cast<Element*>(node);

there is a toElement helper