Bug 113790

Summary: Web Inspector: memory instrumentation for external arrays is broken
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, benjamin, cmarcelo, gyuyoung.kim, keishi, loislo, ojan.autocc, pfeldman, pmuellr, rakuco, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Yury Semikhatsky 2013-04-02 08:58:10 PDT 
r144527 broke this when skipped all raw pointers in the memory instrumentation traversal algorithm. Now we don't see JS externals arrays in the native memory snapshot.
Comment 1 Yury Semikhatsky 2013-04-02 09:06:12 PDT 
Created attachment 196154 [details]
Patch
Comment 2 Ilya Tikhonovsky 2013-04-02 09:13:10 PDT 
Comment on attachment 196154 [details]
Patch

LGTM
Comment 3 WebKit Review Bot 2013-04-02 11:12:39 PDT 
Comment on attachment 196154 [details]
Patch

Clearing flags on attachment: 196154

Committed r147465: <http://trac.webkit.org/changeset/147465>
Comment 4 WebKit Review Bot 2013-04-02 11:12:43 PDT 
All reviewed patches have been landed.  Closing bug.