Summary: | Web Inspector: crash in WebCore::InspectorLayerTreeAgent::buildObjectForLayer if a layer is created for an anonymous RenderObject (:first-letter) | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Antoine Quint <graouts> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | apavlov, joepeck, keishi, loislo, pfeldman, pmuellr, timothy, vsevik, web-inspector-bugs, webkit-bug-importer, webkit.review.bot, yurys | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
URL: | http://sahilparikh.com/post/46741689726/building-a-saas-business-2007-vs-2013 | ||||||||
Attachments: |
|
Description
Antoine Quint
2013-04-02 04:27:17 PDT
Created attachment 196169 [details]
Patch
Comment on attachment 196169 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196169&action=review > Source/WebCore/inspector/InspectorLayerTreeAgent.cpp:206 > + RenderStyle* style = renderer->style(); > + if (style) { FWIW, this can be simplified to: if (RenderStyle* style = renderer->style()) { Comment on attachment 196169 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196169&action=review > Source/WebCore/inspector/InspectorLayerTreeAgent.cpp:175 > + else if (isReflection || isAnonymous) > node = renderer->parent()->node(); Does this always work? What about a :first-letter inside a :first-line? (In reply to comment #4) > (From update of attachment 196169 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=196169&action=review > > > Source/WebCore/inspector/InspectorLayerTreeAgent.cpp:175 > > + else if (isReflection || isAnonymous) > > node = renderer->parent()->node(); > > Does this always work? What about a :first-letter inside a :first-line? Per my testing, that works too. I haven't found a way to have a ::first-letter be composited though, animations don't apply, neither do transforms, etc. Created attachment 196313 [details]
Patch for landing
Comment on attachment 196313 [details] Patch for landing Clearing flags on attachment: 196313 Committed r147538: <http://trac.webkit.org/changeset/147538> All reviewed patches have been landed. Closing bug. |