Summary: | Render images with low-quality scaling while FrameView is being resized. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||
Component: | Layout and Rendering | Assignee: | Andreas Kling <kling> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | anilsson, barraclough, darin, eric, esprehn+autocc, kling, koivisto, ojan.autocc, sam, tonikitoo, webkit-bug-importer, webkit.review.bot | ||||||
Priority: | P2 | Keywords: | InRadar, Performance | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Andreas Kling
2013-04-02 03:10:19 PDT
Created attachment 196115 [details]
Patch idea
Initial stab. Seems to work pretty well on my rMBP, thoughts welcome.
Comment on attachment 196115 [details]
Patch idea
I ran into an issue where GIF animations can cause the ImageQualityController to punt the HQ repaint indefinitely. Retracting patch for now.
Created attachment 196468 [details]
Proposed patch
Use a separate flag in ImageQualityController to determine whether we're in the "live window resize optimization" mode.
Attachment 196468 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderBoxModelObject.cpp']" exit_code: 1
Source/WebCore/rendering/RenderBoxModelObject.cpp:187: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 196468 [details]
Proposed patch
r=me
Comment on attachment 196468 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=196468&action=review > Source/WebCore/rendering/RenderBoxModelObject.cpp:192 > + return true; > + } else if (m_liveResizeOptimizationIsActive) { No need for else after return. Committed r147638: <http://trac.webkit.org/changeset/147638> |