Bug 113753

Summary: Caret need not be moved to horizontal boundary when past top or bottom on Linux
Product: WebKit Reporter: KyungTae Kim <ktf.kim>
Component: HTML EditingAssignee: KyungTae Kim <ktf.kim>
Status: NEW    
Severity: Normal CC: arpitabahuguna, darin, enrica, g.czajkowski, gyuyoung.kim, laszlo.gombos, mifenton, mrobinson, rniwa, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch rniwa: review-

KyungTae Kim
Reported 2013-04-01 23:46:53 PDT
Caret should be moved to horizontal boundary when past top or bottom on Mac, but not on Linux. Other applications on Linux does not have that behavior, so the caret moving behavior is confusing, especially on mobile devices based on Linux.
Attachments
Patch (1.72 KB, patch)
2013-04-01 23:53 PDT, KyungTae Kim 		rniwa: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
KyungTae Kim
Comment 1 2013-04-01 23:53:29 PDT
Created attachment 196082 [details] Patch
Ryosuke Niwa
Comment 2 2013-08-01 19:29:25 PDT
Comment on attachment 196082 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196082&action=review > Source/WebCore/ChangeLog:11 > + No new tests. We definitely need tests. In fact, existing tests will start failing once this patch is landed. > Source/WebCore/editing/EditingBehavior.h:44 > - return m_type != EditingWindowsBehavior && m_type != EditingAndroidBehavior; > + return m_type != EditingWindowsBehavior && m_type != EditingAndroidBehavior && m_type != EditingUnixBehavior; It's probably better to check m_type == EditingMacBehavior instead.
Note You need to log in before you can comment on or make changes to this bug.