Summary: | WebKit/mac shouldn't have code for Mac 10.5 and earlier | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||||
Component: | New Bugs | Assignee: | Ryosuke Niwa <rniwa> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | benjamin, buildbot, darin, eric, morrita, mrowe, rniwa | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 113749 | ||||||||||
Attachments: |
|
Description
Ryosuke Niwa
2013-04-01 22:27:11 PDT
Created attachment 196072 [details]
Delete code for 10.5 and earlier from WebKit/mac
Created attachment 196073 [details]
Removed unused function
Comment on attachment 196073 [details] Removed unused function View in context: https://bugs.webkit.org/attachment.cgi?id=196073&action=review > Source/WebKit/mac/Misc/WebNSFileManagerExtras.mm:-39 > -#if __MAC_OS_X_VERSION_MIN_REQUIRED == 1060 Removing this isn't consistent with the description of your patch. > Source/WebKit/mac/WebView/WebView.mm:1472 > + settings->setNeedsLeopardMailQuirks(false); This is an obvious candidate for removal. Comment on attachment 196073 [details] Removed unused function Attachment 196073 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17301523 Comment on attachment 196073 [details] Removed unused function View in context: https://bugs.webkit.org/attachment.cgi?id=196073&action=review >> Source/WebKit/mac/Misc/WebNSFileManagerExtras.mm:-39 >> -#if __MAC_OS_X_VERSION_MIN_REQUIRED == 1060 > > Removing this isn't consistent with the description of your patch. Oops, nice catch. I was initially removing 1060 code. Let me revert that. (In reply to comment #3) > (From update of attachment 196073 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=196073&action=review > > > Source/WebKit/mac/WebView/WebView.mm:1472 > > + settings->setNeedsLeopardMailQuirks(false); > > This is an obvious candidate for removal. Yeah, I’m going to do that in a separate patch though since that involves both WebKit and WebCore changes. Created attachment 196077 [details]
Fixed per Mark's comments
Comment on attachment 196077 [details] Fixed per Mark's comments View in context: https://bugs.webkit.org/attachment.cgi?id=196077&action=review > Source/WebKit/mac/WebView/WebView.mm:1472 > + settings->setNeedsLeopardMailQuirks(false); I don’t think we need this line at all. This defaults to false and we will never set it to true. So please delete this. In fact, as a followup we could remove this setting from WebCore entirely. Committed as https://trac.webkit.org/r147447. |