Bug 113746

Summary: WebKit/mac shouldn't have code for Mac 10.5 and earlier
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, darin, eric, morrita, mrowe, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 113749    
Attachments:
Description Flags
Delete code for 10.5 and earlier from WebKit/mac
none
Removed unused function
none
Fixed per Mark's comments darin: review+

Ryosuke Niwa
Reported 2013-04-01 22:27:11 PDT
WebKit/mac shouldn't have code for Mac 10.5 and earlier
Attachments
Delete code for 10.5 and earlier from WebKit/mac (41.86 KB, patch)
2013-04-01 22:28 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Removed unused function (42.06 KB, patch)
2013-04-01 22:41 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixed per Mark's comments (41.98 KB, patch)
2013-04-01 23:27 PDT, Ryosuke Niwa 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-04-01 22:28:06 PDT
Created attachment 196072 [details] Delete code for 10.5 and earlier from WebKit/mac
Ryosuke Niwa
Comment 2 2013-04-01 22:41:27 PDT
Created attachment 196073 [details] Removed unused function
Mark Rowe (bdash)
Comment 3 2013-04-01 22:45:54 PDT
Comment on attachment 196073 [details] Removed unused function View in context: https://bugs.webkit.org/attachment.cgi?id=196073&action=review > Source/WebKit/mac/Misc/WebNSFileManagerExtras.mm:-39 > -#if __MAC_OS_X_VERSION_MIN_REQUIRED == 1060 Removing this isn't consistent with the description of your patch. > Source/WebKit/mac/WebView/WebView.mm:1472 > + settings->setNeedsLeopardMailQuirks(false); This is an obvious candidate for removal.
Build Bot
Comment 4 2013-04-01 23:09:24 PDT
Comment on attachment 196073 [details] Removed unused function Attachment 196073 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17301523
Ryosuke Niwa
Comment 5 2013-04-01 23:13:46 PDT
Comment on attachment 196073 [details] Removed unused function View in context: https://bugs.webkit.org/attachment.cgi?id=196073&action=review >> Source/WebKit/mac/Misc/WebNSFileManagerExtras.mm:-39 >> -#if __MAC_OS_X_VERSION_MIN_REQUIRED == 1060 > > Removing this isn't consistent with the description of your patch. Oops, nice catch. I was initially removing 1060 code. Let me revert that.
Ryosuke Niwa
Comment 6 2013-04-01 23:16:58 PDT
(In reply to comment #3) > (From update of attachment 196073 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=196073&action=review > > > Source/WebKit/mac/WebView/WebView.mm:1472 > > + settings->setNeedsLeopardMailQuirks(false); > > This is an obvious candidate for removal. Yeah, I’m going to do that in a separate patch though since that involves both WebKit and WebCore changes.
Ryosuke Niwa
Comment 7 2013-04-01 23:27:11 PDT
Created attachment 196077 [details] Fixed per Mark's comments
Darin Adler
Comment 8 2013-04-02 09:45:25 PDT
Comment on attachment 196077 [details] Fixed per Mark's comments View in context: https://bugs.webkit.org/attachment.cgi?id=196077&action=review > Source/WebKit/mac/WebView/WebView.mm:1472 > + settings->setNeedsLeopardMailQuirks(false); I don’t think we need this line at all. This defaults to false and we will never set it to true. So please delete this. In fact, as a followup we could remove this setting from WebCore entirely.
Ryosuke Niwa
Comment 9 2013-04-02 10:34:30 PDT
Committed as https://trac.webkit.org/r147447.
Note You need to log in before you can comment on or make changes to this bug.