Bug 113703 – [CSS Regions] Content that has overflow: scroll cannot be scrolled by dragging the scroll thumbs with the mouse

• Component: CSS
• Status: RESOLVED FIXED

[Mihai Balan]

Created attachment 195974 [details]
Test-case

If a content node has a specified size and overflow: scroll and the content is larger than the specified size, scrollbars will be drawn.

However, the content cannot be scrolled using the scrollbars, only using the scroll wheel, the cursor keys or (in Chrome) by pushing the middle mouse buttons.
When moving the mouse cursor over the scrollbars they will react to the "hover", but clicking and dragging the scroll "thumb" will do nothing (thumb won't move, content won't scroll).

[Mihai Maerean]

Created attachment 203055 [details]
patch

[Darin Adler]

Comment on attachment 203055 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203055&action=review

r=me, but please fix the style issue

> Source/WebCore/rendering/RenderBoxModelObject.cpp:2859
> +        RenderRegion* startRegion, *endRegion;

We never declare multiple variables on a single line like this. It’s particularly confusing style to do it with pointers, since we typically put the "*" by the type and ignore the fact that C syntax doesn’t work that way. This line of code forces the issue. Just use two separate definitions on two separate lines to do away with that potential confusion.

[Mihai Maerean]

Created attachment 203136 [details]
patch for landing.

[WebKit Commit Bot]

Comment on attachment 203136 [details]
patch for landing.

Rejecting attachment 203136 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 203136, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/677581

[Mihai Maerean]

Created attachment 203140 [details]
patch for landing.

[WebKit Commit Bot]

Comment on attachment 203140 [details]
patch for landing.

Clearing flags on attachment: 203140

Committed r150881: <http://trac.webkit.org/changeset/150881>