Bug 113696

Summary: Web Inspector: [Network] dataURIs are listed as separate requests in HAR.
Product: WebKit Reporter: Eugene Klyuchnikov <eustas>
Component: Web Inspector (Deprecated)Assignee: Eugene Klyuchnikov <eustas>
Status: RESOLVED WONTFIX    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Eugene Klyuchnikov
Reported 2013-04-01 04:12:39 PDT
Original issue: https://code.google.com/p/chromium/issues/detail?id=175979 dataURIs should not have separate entries as their network impact is already included in other entries. E.g. a CSS background image dataURI would be included in the entry for the CSS file download etc.
Attachments
Patch (2.80 KB, patch)
2013-04-01 04:16 PDT, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Patch (5.12 KB, patch)
2013-04-01 23:28 PDT, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Patch (5.74 KB, patch)
2013-04-01 23:52 PDT, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Patch (5.99 KB, patch)
2013-04-02 23:14 PDT, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Eugene Klyuchnikov
Comment 1 2013-04-01 04:16:42 PDT
Created attachment 195952 [details] Patch
Pavel Feldman
Comment 2 2013-04-01 05:07:51 PDT
Comment on attachment 195952 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195952&action=review > Source/WebCore/inspector/front-end/NetworkPanel.js:1150 > + return request.parsedURL.isValid; You should explicitly check for data url. Btw, do we really want to see data urls in the network panel by default? A test?
Eugene Klyuchnikov
Comment 3 2013-04-01 23:28:00 PDT
Created attachment 196078 [details] Patch
Eugene Klyuchnikov
Comment 4 2013-04-01 23:52:37 PDT
Created attachment 196081 [details] Patch
Pavel Feldman
Comment 5 2013-04-02 07:22:31 PDT
Comment on attachment 196081 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196081&action=review > Source/WebCore/inspector/front-end/NetworkPanel.js:98 > +WebInspector.NetworkLogView.HTTPSchemas = {"http": true, "https": true, "ws": true}; What about wss, file schemes? "HttpShemes".
Eugene Klyuchnikov
Comment 6 2013-04-02 22:46:53 PDT
Comment on attachment 196081 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196081&action=review >> Source/WebCore/inspector/front-end/NetworkPanel.js:98 >> +WebInspector.NetworkLogView.HTTPSchemas = {"http": true, "https": true, "ws": true}; > > What about wss, file schemes? > "HttpShemes". wss - done. file - no, because it is not network/HTTP schema.
Eugene Klyuchnikov
Comment 7 2013-04-02 23:14:33 PDT
Created attachment 196284 [details] Patch
Note You need to log in before you can comment on or make changes to this bug.