Summary: | REGRESSION (r147241): Failures in three IDB layout tests on GTK | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ggaren, haraken, jsbell, michael, mrobinson, oliver, webkit.review.bot | ||||
Priority: | P2 | Keywords: | Gtk, LayoutTestFailure, Regression | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 113091 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Zan Dobersek
2013-04-01 01:43:12 PDT
Created attachment 195998 [details]
Patch
Sorry about that. We need to try and get ScriptState and SSV better aligned *internally* in the V8 binding and between V8 and and JSC. Some vague notes in https://bugs.webkit.org/show_bug.cgi?id=113091 Apologies for not anticipating this failure. :( (In reply to comment #2) > Sorry about that. We need to try and get ScriptState and SSV better aligned *internally* in the V8 binding and between V8 and and JSC. > > Some vague notes in https://bugs.webkit.org/show_bug.cgi?id=113091 > > Apologies for not anticipating this failure. :( The JSC implementation of ScriptValue::serialize(ScriptState*, MessagePortArray*, ArrayBufferArray*, bool&), added in r116763, was flawed in that it called the specialized SerializedScriptValue::create(JSContextRef, JSValueRef, MessagePortArray*, ArrayBufferArray*, JSValueRef*). This variant of SerializedScriptValue::create(), which returns the exception thrown in its final parameter and clears the exception on the JSContextRef, was intended for use in the WebKit layer and not in WebCore bindings (r51256). The fix in r147241 exposed this formerly latent error. Comment on attachment 195998 [details]
Patch
Although a right way to fix the bug would be making SSV's APIs better (in both V8 and JSC), this looks reasonable as an immediate fix.
Comment on attachment 195998 [details] Patch Clearing flags on attachment: 195998 Committed r147382: <http://trac.webkit.org/changeset/147382> All reviewed patches have been landed. Closing bug. |