Summary: | Use Vector::reserveInitialCapacity and Vector::uncheckedAppend for JSC's APIs | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||
Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Benjamin Poulain
2013-03-30 20:46:18 PDT
Created attachment 195885 [details]
Patch
Comment on attachment 195885 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195885&action=review Sure, r=me. > Source/JavaScriptCore/API/JSCallbackConstructor.cpp:79 > + for (size_t i = 0; i < argumentCount; i++) If I was driving by in this neighborhood, I'd change the i++ to ++i because reasons. > Source/JavaScriptCore/API/JSCallbackFunction.cpp:75 > + for (size_t i = 0; i < argumentCount; i++) And here. > Source/JavaScriptCore/API/JSCallbackObjectFunctions.h:374 > + for (size_t i = 0; i < argumentCount; i++) Probably also here. > Source/JavaScriptCore/API/JSCallbackObjectFunctions.h:441 > + for (size_t i = 0; i < argumentCount; i++) Not sure about here. Well, yeah okay here too. Committed r147349: <http://trac.webkit.org/changeset/147349> |