Summary: | Crash when "willSendRequest" causes the ResourceLoader to be cancelled. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
Component: | WebKit2 | Assignee: | Brady Eidson <beidson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Brady Eidson
2013-03-29 15:47:34 PDT
Created attachment 195811 [details]
Patch v1
Comment on attachment 195811 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=195811&action=review > Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp:161 > + ASSERT(loader); > + if (!loader) > + return; How strongly do you feel about this? We usually do not not add such checks without knowing that this actually happens, and waiting for reproducible cases. (In reply to comment #2) > (From update of attachment 195811 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=195811&action=review > > > Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp:161 > > + ASSERT(loader); > > + if (!loader) > > + return; > > How strongly do you feel about this? We usually do not not add such checks without knowing that this actually happens, and waiting for reproducible cases. I don't feel strongly about it, I'll remove it. (leaving the ASSERT) |